[GENIUS-275] wrong condition statement in update method in TunnelInventoryStateListener.java Created: 07/May/19  Updated: 08/Jan/20  Resolved: 08/Jan/20

Status: Resolved
Project: genius
Component/s: ITM
Affects Version/s: None
Fix Version/s: None

Type: Bug Priority: High
Reporter: Yi Yang Assignee: Yi Yang
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

genius master

Priority: Highest

 Description   

the below condition statement in update method in TunnelInventoryStateListener.java is wrong：

diff --git a/itm/itm-impl/src/main/java/org/opendaylight/genius/itm/itmdirecttunnels
index c077d6a..3b6b6b9 100644
— a/itm/itm-impl/src/main/java/org/opendaylight/genius/itm/itmdirecttunnels/listen
+++ b/itm/itm-impl/src/main/java/org/opendaylight/genius/itm/itmdirecttunnels/listen
@@ -139,7 +139,7 @@ public class TunnelInventoryStateListener extends
@NonNull FlowCapableNodeConnector fcNodeConnectorOld,
@NonNull FlowCapableNodeConnector fcNodeConnectorNew) {
String portName = fcNodeConnectorNew.getName();

  • if (DirectTunnelUtils.TUNNEL_PORT_PREDICATE.test(portName)) {
    + if (!DirectTunnelUtils.TUNNEL_PORT_PREDICATE.test(portName)) {
    LOG.debug("Node Connector Update - {} Interface is not a tunnel I/f, so
    return;
    } else if (!dpnTepStateCache.isInternal(portName)) {

 

 Comments   
Comment by Hema Gopalakrishnan [ 08/Jan/20 ]

Hi Yi Yang,

  Is there any update on this Jira ?

Comment by Yi Yang [ 08/Jan/20 ]

This has been fixed by the below commit:

commit e9769581c0c42901a36e071f6dc53e67fe87c75c
Author: Yi Yang <yangyi01@inspur.com>
Date: Mon May 6 21:06:39 2019 -0400

Fix wrong condition statement in update method

In update method in TunnelInventoryStateListener.java,
the below condition is wrong obviously.

if (DirectTunnelUtils.TUNNEL_PORT_PREDICATE.test(portName)) {
LOG.debug("Node Connector Update - {} Interface is not ...
return;
}

JIRA: GENIUS-275

Change-Id: I0b03d7357edb37baf0f535d06dd3a72952b387f5
Signed-off-by: Yi Yang <yangyi01@inspur.com>

Generated at Wed Feb 07 20:00:21 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.