[GENIUS-281] genius.utils.batching.ActionableResource is inefficient Created: 28/Oct/19  Updated: 24/Jul/20  Resolved: 24/Jul/20

Status: Resolved
Project: genius
Component/s: mdsalutils
Affects Version/s: None
Fix Version/s: Aluminium

Type: Bug Priority: Medium
Reporter: Robert Varga Assignee: Hema Gopalakrishnan
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

ActionableResource has a number of deficiencies:

  • the interface seems to be mutable, where in fact is really is not
  • each resource requires a key, which is only ever used impossible cases – and it forces clients to come up with Strings. Users resort to inefficient use to toString() on various objects, mostly InstanceIdentifier
  • the interface hides really four distinct polymorphic cases, each of which should be tightly encapsulated

Rework the interface so it addresses all these concerns.

 Comments   
Comment by Robert Varga [ 28/Oct/19 ]

I think this is ready – the seven patches combined mean that there is no InstanceIdentifier.toString() nor String concatenation involved when batching these, without causing any loss of functionality.

Generated at Wed Feb 07 20:00:22 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.