[GENIUS-52] FlowBasedServicesConfigListener update() causes false positive ERRORS Created: 18/Jan/17  Updated: 19/Oct/17  Resolved: 22/Jan/17

Status: Resolved
Project: genius
Component/s: General
Affects Version/s: (unspecified)
Fix Version/s: None

Type: Bug
Reporter: Guy Sela Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 7576

 Description   

Code looks like this:
@Override
protected void update(InstanceIdentifier<BoundServices> key, BoundServices boundServiceOld,
BoundServices boundServiceNew) {
LOG.error("Service Binding entry update not allowed for: {}, Data: {}",
InstanceIdentifier.keyOf(key.firstIdentifierOf(ServicesInfo.class)).getInterfaceName(),
boundServiceNew);
}

update() from MD-SAL can be called spuriously with THE SAME old and new entity. Should check that this is not the case before writing ERROR to log. From the javadoc of DataTreeChangeListener:
"
A data change event may be triggered spuriously, e.g. such that data before

  • and after compare as equal. Implementations of this interface are expected
  • to recover from such events. Event producers are expected to exert reasonable
  • effort to suppress such events.
    "


 Comments   
Comment by Koby Aizer [ 22/Jan/17 ]

Review: https://git.opendaylight.org/gerrit/#/c/50613/

Generated at Wed Feb 07 19:59:47 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.