[GENIUS-62] lock-manager-impl floods logs with OptimisticLockFailedExceptions Created: 23/Mar/17  Updated: 14/May/18  Resolved: 14/May/18

Status: Resolved
Project: genius
Component/s: General
Affects Version/s: (unspecified)
Fix Version/s: Oxygen

Type: Bug
Reporter: Robert Varga Assignee: Kency Kurian
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 8059

 Description   

2017-03-21 15:06:39,659 | ERROR | eChangeHandler-0 | LockManager | 351 - org.opendaylight.genius.lockmanager-impl - 0.2.0.SNAPSHOT | Unable to acquire lock, try 1
java.util.concurrent.ExecutionException: OptimisticLockFailedException

{message=Optimistic lock failed., errorList=[RpcError [message=Optimistic lock failed., severity=ERROR, errorType=APPLICATION, tag=resource-denied, applicationTag=null, info=null, cause=org.opendaylight.yangtools.yang.data.api.schema.tree.ConflictingModificationAppliedException: Node was created by other transaction.]]}

As per definition in Logging Best Practices, this should be a WARN, as there is a retry mechanism in place.

I am not familiar with the design of the lock manager, but it seems it could be using EntityOwnershipService, which already provides cluster-wide exclusive locking.

If the exceptions are direct result of application design and retries are expected, the message should be lowered to debug.

 Comments   
Comment by Michael Vorburger [ 13/Apr/17 ]

> it seems it could be using EntityOwnershipService, which already provides

Let's quick fix up the logging under this bug here, and let's use GENIUS-73 for a possible enhancement to change the implementation (thank you Robert for bringing up the idea!).

Comment by Sam Hague [ 19/Aug/17 ]

https://git.opendaylight.org/gerrit/61977

Comment by Michael Vorburger [ 14/Sep/17 ]

https://git.opendaylight.org/gerrit/#/c/63121/

Comment by Faseela K [ 10/May/18 ]

vorburger Can this Jira be closed?

Comment by Michael Vorburger [ 14/May/18 ]

done

Generated at Wed Feb 07 19:59:49 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.