[GENIUS-7] Actions may be overridden when used in combination with getEgressActionsForInterface Created: 16/Aug/16  Updated: 27/Feb/18  Resolved: 27/Feb/18

Status: Resolved
Project: genius
Component/s: General
Affects Version/s: (unspecified)
Fix Version/s: None

Type: Bug
Reporter: Tali Ben-Meir Assignee: Jaime Caamaño Ruiz
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 6441

 Description   

The following code is expected to create the following OF actions
actions=set_field:00:1c:73:4e:d3:31->eth_dst,load:0x100->NXM_NX_REG6[],resubmit(,220)

List<ActionInfo> actionList = new ArrayList<>();
actionList.add(new ActionInfo(ActionType.set_field_eth_dest, new String[]

{ macAddress }

));
List<ActionInfo> egressActionList = NatUtil.getEgressActionsForInterface(interfaceManager, extInterface, null);
actionList.addAll(egressActionList);

Instead, only the egress actions are created and set_field will be discarded due to internal ordering created by OdlInterfaceRpcService.getEgressActionsForInterface()

A workaround for this can be forcing the order using ActionInfo c'tor with order parameter. But why is an ordered collection like List needs an additional ordering?

 Comments   
Comment by Faseela K [ 08/Aug/17 ]

Jaime,

Could you please see if your below patch which was merged sometime back solves the same problem in the bug?

https://git.opendaylight.org/gerrit/#/c/57645/

Comment by Jaime Caamaño Ruiz [ 08/Aug/17 ]

Hello Faseela

Does not look like so. The aforementioned fix happens at the time of service binding only.

Tali, since you are prepending your own action to the list of actions, are you passing an incremented action key to OdlInterfaceRpcService.getEgressActionsForInterface? If not, it defaults to 0 where it should be 1 since the first at 0 would be your own.

Jaime.

Comment by Faseela K [ 08/Aug/17 ]

In that case, I think we can close this bug

Comment by Jaime Caamaño Ruiz [ 27/Feb/18 ]

I am closing this due to inactivity. Please reopen if necessary.

Generated at Wed Feb 07 19:59:40 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.