[GENIUS-93] NPE in DataStoreJobCoordinator$InfrautilsRollbackCallableDelegate.call() Created: 26/Oct/17 Updated: 19/Apr/18 Resolved: 19/Apr/18 |
|
| Status: | Resolved |
| Project: | genius |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Oxygen |
| Type: | Bug | Priority: | Medium |
| Reporter: | Michael Vorburger | Assignee: | Michael Vorburger |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
CSIT run of https://git.opendaylight.org/gerrit/#/c/60303/ (together with https://git.opendaylight.org/gerrit/#/c/60300/) in https://logs.opendaylight.org/releng/jenkins092/netvirt-csit-1node-openstack-pike-upstream-stateful-snat-conntrack-oxygen/31/odl1_karaf.log.gz is causing: 2017-10-25 16:48:58,978 | ERROR | nPool-1-worker-2 | JobCoordinatorImpl | 259 - org.opendaylight.infrautils.jobcoordinator-impl - 1.3.0.SNAPSHOT | Exception when executing jobEntry: JobEntry{key='FIB-100071-236023102138698', mainWorker=null, rollbackWorker=org.opendaylight.genius.datastoreutils.DataStoreJobCoordinator$InfrautilsRollbackCallableDelegate@3ba0160f, retryCount=0, futures=[org.opendaylight.controller.cluster.databroker.ConcurrentDOMDataBroker$AsyncNotifyingSettableFuture@7ea29f1f]}
java.lang.NullPointerException
at org.opendaylight.genius.datastoreutils.DataStoreJobCoordinator$InfrautilsRollbackCallableDelegate.call(DataStoreJobCoordinator.java:113)[248:org.opendaylight.genius.mdsalutil-api:0.4.0.SNAPSHOT]
at org.opendaylight.genius.datastoreutils.DataStoreJobCoordinator$InfrautilsRollbackCallableDelegate.call(DataStoreJobCoordinator.java:102)[248:org.opendaylight.genius.mdsalutil-api:0.4.0.SNAPSHOT]
at org.opendaylight.infrautils.jobcoordinator.internal.JobCoordinatorImpl$RollbackTask.runWithUncheckedExceptionLogging(JobCoordinatorImpl.java:251)[259:org.opendaylight.infrautils.jobcoordinator-impl:1.3.0.SNAPSHOT]
at org.opendaylight.infrautils.utils.concurrent.LoggingUncaughtThreadDeathContextRunnable.run(LoggingUncaughtThreadDeathContextRunnable.java:60)[262:org.opendaylight.infrautils.util:1.3.0.SNAPSHOT]
|
| Comments |
| Comment by Michael Vorburger [ 26/Oct/17 ] |
|
I think the problem here is that some existing code seems to call the DataStoreJobCoordinator (JobCoordinator) API with a null RollbackCallable rollbackWorker .. I'll make changes to take that into account! |
| Comment by Michael Vorburger [ 26/Oct/17 ] |
|
https://git.opendaylight.org/gerrit/#/c/63961/ already made sure that there can be no more NPEs in infrautils.jobcoordinator; what was missing was genius DataStoreJobCoordinator, and https://git.opendaylight.org/gerrit/#/c/60303/17..18/mdsalutil/mdsalutil-api/src/main/java/org/opendaylight/genius/datastoreutils/DataStoreJobCoordinator.java should take care of that. |