[HONEYVBD-14] Migrate IETF Yang files to Mdsal project Created: 04/Jan/17  Updated: 14/Nov/17

Status: Confirmed
Project: honeycomb-vbd
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Vratko Polak Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 7479

 Description   

Standard Yang files used in ODL should be stored in one place in order to keep revisions under control. Currently the place is in Mdsal project (model/ subdirectories).

When multiple revisions of the same module are present in ODL container, care should be taken. Additional filenames should contain revision (e.g. ietf-inet-types@2013-07-15.yang) and each import statement should use revision-date to avoid unexpected errors when parsing.

An example of such error is shown in comments on patch set 2 of https://git.opendaylight.org/gerrit/49828

 Comments   
Comment by Michal Cmarada [ 11/Jan/17 ]

I prepared a fix for this. https://git.opendaylight.org/gerrit/#/c/50286/.

We just need to test it because this model comes from honeycomb project in FD.io and it was not made by us, but it should be fine, the model didn`t change its just the file name and revision in imports that changed.

Comment by Vratko Polak [ 11/Jan/17 ]

> a fix for this https://git.opendaylight.org/gerrit/50286

Well, description of this Bug asks for moving all the ietf yang the files to mdsal.models and for using revision-date on every import (not just ietf-routing), but 50286 is a step in the right direction.

Comment by Vratko Polak [ 13/Jan/17 ]

There is a problem specific to ietf-routing, tracked as a PERSISTENC-1.

This Bug still applies, as other IETF files may lead to similar problems later,
and Mdsal project (as the host for standard Yang files) would be able to solve them authoritatively for all ODL projects.

Comment by Vratko Polak [ 20/Jan/17 ]

Mdsal Carbon: https://git.opendaylight.org/gerrit/50683

When that is merged, VBD code should start using that.

Comment by Vratko Polak [ 22/Mar/17 ]

Too late in Carbon cycle to make such a big API change.

Generated at Wed Feb 07 20:01:42 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.