[INFRAUTILS-16] JobCoordinator enqueueJob must return a ListenableFuture instead of void Created: 22/Sep/17 Updated: 29/Sep/20 Resolved: 29/Sep/20 |
|
| Status: | Resolved |
| Project: | infrautils |
| Component/s: | General |
| Affects Version/s: | Oxygen |
| Fix Version/s: | 1.9.0 |
| Type: | Improvement | Priority: | Low |
| Reporter: | Michael Vorburger | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Issue Links: |
|
||||||||||||||||
| Description |
|
JobCoordinator enqueueJob must not return void but a (List of or single compound?) ListenableFuture, or a CompletionStage. This will let clients await completion of the submitted job, or at very least attach error logging, with context. (Client will ideally do this non-blocking through future chaining, not blocking get.)
Let us do this only in infrautils, and not in parallel in the duplicated code in infrautils as well as its origin in genius, because https://git.opendaylight.org/gerrit/#/c/60303/ is (hopefully) about to be finally merged. |
| Comments |
| Comment by Michael Vorburger [ 22/Sep/17 ] |
|
GENIUS-91 is the full background / context where this came up (again) today... |
| Comment by Michael Vorburger [ 15/Mar/18 ] |
|
This has recently come up again in thread "Jobcoordinator enhancement query" on infrautils-dev. |
| Comment by Michael Vorburger [ 22/Mar/18 ] |
|
gobinath is contributing this in https://git.opendaylight.org/gerrit/#/c/69660/ ... |
| Comment by Arunprakash D [ 18/Jul/19 ] |
|
This change is no longer needed and the review has been abandoned. We can close this Jira as well. |