I think I made a fairly major logical design "thinko" mistake in SystemReady.registerListener(SystemReadyListener) - it's broken if the system is ALREADY active! 
Fixing coming up ASAP.
k.faseela FYI.
[INFRAUTILS-44] SystemReady.registerListener(SystemReadyListener) is broken is system if already active Created: 07/Jun/18 Updated: 12/Jun/18 Resolved: 12/Jun/18 |
|
| Status: | Resolved |
| Project: | infrautils |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Oxygen-SR3, Fluorine |
| Type: | Bug | Priority: | Medium |
| Reporter: | Michael Vorburger | Assignee: | Michael Vorburger |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||
| Description |
|
I think I made a fairly major logical design "thinko" mistake in SystemReady.registerListener(SystemReadyListener) - it's broken if the system is ALREADY active! Fixing coming up ASAP. k.faseela FYI. |
| Comments |
| Comment by Michael Vorburger [ 07/Jun/18 ] |
|
https://git.opendaylight.org/gerrit/#/c/72766/ raised for master; I'll cherry-pick to stable/oxygen when merged. FTR: I've stumbled upon this while working on |
| Comment by Faseela K [ 07/Jun/18 ] |
|
vorburger : But in normal scenarios such a failure cannot happen, if bundles do the registration in their constructors right? We don't have a case where system is ACTIVE, and still people are registering for system ready?? will that happen? |
| Comment by Michael Vorburger [ 07/Jun/18 ] |
|
k.faseela you are right re. current usages that I'm aware of, BUT nothing in the current API enforces this - one CAN use it at any time. In which case, as things are, it will just get ignored, which is very bad. And in c/72767 for |