[INFRAUTILS-45] Use /diagstatus JSON to fetch remote status instead of JMX RMI Created: 27/Jul/18 Updated: 12/Dec/18 Resolved: 12/Dec/18 |
|
| Status: | Verified |
| Project: | infrautils |
| Component/s: | diagstatus |
| Affects Version/s: | None |
| Fix Version/s: | Neon |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Faseela K | Assignee: | Faseela K |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||
| Description |
|
diagstatus currently uses JMX RMI to fetch service status from remote nodes in an ODL cluster. diagstatus implementation already supports fetching the status with JSON over HTTP. And would be good to migrate the CLI to use the same instead of JMX RMI, so that we can reduce the overhead of opening an additional port for RMI, and all other related concerns. |
| Comments |
| Comment by Michael Vorburger [ 27/Jul/18 ] |
|
> diagstatus implementation already supports fetching the status with JSON over HTTP
As part of this work, we should just completely remove all of the JMX related code in diagstatus. For the JSON processing, can I suggest that instead of writing the inverse of the getAllServiceDescriptorsAsJSON() method with a JsonReader, we use this as the opportunity to write a small Java class describing the structure of the JSON message (as it is now, to remain fully backwards compatible), and use GSON to map a JSON string from and to that class. |
| Comment by Michael Vorburger [ 14/Nov/18 ] |
|
k.faseela while I'm reviewing your c/77730, I'm realizing that this is a fairly major implementation change, and thought it could be worthwhile to clarify what target Fix Version you had in mind for this? Obviously master/Neon - only? Fine for me. I would be slightly reluctant to accept this e.g. for stable/oxygen - just because we spent some time to stabilize this feature there (with HTTP GET vs. HEAD and IPv6 related and what not other issues we hit over the last few months on this front), personally I would be against rocking that old stable boat. |
| Comment by Faseela K [ 14/Nov/18 ] |
|
Neon alone should be good enough vorburger! |