[INFRAUTILS-53] The errorprone setup doesn’t support JDK 9+ Created: 24/Sep/18 Updated: 23/Jul/20 Resolved: 23/Jul/20 |
|
| Status: | Resolved |
| Project: | infrautils |
| Component/s: | General |
| Affects Version/s: | Neon |
| Fix Version/s: | 1.8.0 |
| Type: | Bug | Priority: | Medium |
| Reporter: | Stephen Kitt | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Currently, when the errorprone profile ends up being activated, the build fails with JDK 9 or later. The documentation isn’t all that clear about how to fix this (I gather we should drop javac-with-errorprone but haven’t found a configuration which works without that). |
| Comments |
| Comment by Michael Vorburger [ 24/Sep/18 ] |
|
skitt I did some quick Google-ing, and found https://github.com/google/error-prone/issues/448 ending with "Java 9, 10, and 11 are supported now" and "We need up update the rest of the build system installation docs to mention the -Xplugin integration" ... and https://github.com/google/error-prone/issues/860 which closed just a month ago - unclear to me if that is already avialable in the release we use. At the end of http://errorprone.info/docs/installation there is something about -Xplugin, but they seem to be behind on clear instructions for Maven. Perhaps we should open a new issue for error-prone to ask for advise - and contribute a PR to EP for a Maven how-to under Java 11, once we figure it out? |
| Comment by Michael Vorburger [ 24/Sep/18 ] |
|
skitt this https://github.com/google/error-prone/issues/860#issuecomment-396154710 looks pretty interesting, but I think that's what you've just done in https://git.opendaylight.org/gerrit/#/c/76417/1..2 ... |
| Comment by Robert Varga [ 23/Jul/20 ] |
|
Fixed in https://git.opendaylight.org/gerrit/q/I634798fbab8cbb482b2d64904846430152603943 |