[INFRAUTILS-60] JobCoordinator key Object instead String Created: 13/Nov/18  Updated: 29/Sep/20  Resolved: 29/Sep/20

Status: Resolved
Project: infrautils
Component/s: None
Affects Version/s: None
Fix Version/s: 1.9.0

Type: Improvement Priority: Medium
Reporter: Michael Vorburger Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks GENIUS-237 Excessive toString() in EntityOwnersh... Resolved

 Description   

GENIUS-237 hit an issue of apparent excessive toString(), and turns out to be due to be just because JobCoordinator's enqueueJob() requires a String key argument.

Looking into this see, we see that JobCoordinator's implementation doesn't actually really require a String - just a key for a Map (so that "Jobs with the same key are run sequentially. Jobs with different keys are run in parallel.")

Why don't we therefore change the JobCoordinator API & Impl so key can be any Object instead String - that way we can save caller any "artificial" (unnecessary) toString invocations.

 Comments   
Comment by Michael Vorburger [ 16/Nov/18 ]

https://git.opendaylight.org/gerrit/#/c/77784/ has a starting point which could be picked up if there was no interest for this.

GENIUS-237 can be resolved without this in the short term.

Generated at Wed Feb 07 20:02:09 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.