[INTDIST-42] config-pusher error in messaging4transport when install odl-integration-compatible-with-all Created: 27/Oct/15 Updated: 03/May/18 Resolved: 03/Dec/15 |
|
| Status: | Resolved |
| Project: | integration-distribution |
| Component/s: | Features |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Jamo Luhrsen | Assignee: | Pradeeban Kathiravelu |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Issue Links: |
|
||||||||
| External issue ID: | 4535 | ||||||||
| Description |
|
There is something odd about this issue, as I don't see it happening in upstream CSIT jobs simple steps for me to reproduce: 1) opendaylight-user@root>repo-add mvn:org.opendaylight.integration/features-integration-test/0.4.0-SNAPSHOT/xml/features 2) line 124:13 extraneous input ',' expecting {'}', SEP, IDENTIFIER} line 93:0 extraneous input '}' expecting {<EOF>, SEP} line 124:13 extraneous input ',' expecting {'}', SEP, IDENTIFIER}opendaylight-user@root>line 124:13 extraneous input ',' expecting {'} ', SEP, IDENTIFIER} at org.opendaylight.controller.config.manager.impl.ConfigTransactionControllerImpl.secondPhaseCommit(ConfigTransactionControllerImpl.java:427) at org.opendaylight.controller.config.manager.impl.ConfigRegistryImpl.secondPhaseCommit(ConfigRegistryImpl.java:280) at org.opendaylight.controller.config.manager.impl.ConfigRegistryImpl.commitConfig(ConfigRegistryImpl.java:227) at sun.reflect.GeneratedMethodAccessor52.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71) at sun.reflect.GeneratedMethodAccessor33.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275) at com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193) at com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175) at com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117) at com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54) at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237) at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138) at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252) at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819) at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801) at com.sun.jmx.mbeanserver.MXBeanProxy$InvokeHandler.invoke(MXBeanProxy.java:150) at com.sun.jmx.mbeanserver.MXBeanProxy.invoke(MXBeanProxy.java:167) at javax.management.MBeanServerInvocationHandler.invoke(MBeanServerInvocationHandler.java:258) at com.sun.proxy.$Proxy23.commitConfig(Unknown Source) at org.opendaylight.controller.config.util.ConfigRegistryJMXClient.commitConfig(ConfigRegistryJMXClient.java:110) at org.opendaylight.controller.config.facade.xml.transactions.TransactionProvider.commitTransaction(TransactionProvider.java:145) at org.opendaylight.controller.config.facade.xml.ConfigSubsystemFacade.commitSilentTransaction(ConfigSubsystemFacade.java:138) at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.pushConfig(ConfigPusherImpl.java:292) at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.pushConfigWithConflictingVersionRetries(ConfigPusherImpl.java:144) at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.internalPushConfigs(ConfigPusherImpl.java:114) at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.processSingle(ConfigPusherImpl.java:81) at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.process(ConfigPusherImpl.java:74) at org.opendaylight.controller.config.persist.impl.osgi.ConfigPersisterActivator$2.run(ConfigPersisterActivator.java:131) at java.lang.Thread.run(Thread.java:745) Caused by: java.lang.IllegalStateException: Error in createInstance - null is not allowed as return value. Module: ModuleIdentifier{factoryName='messaging4transport', instanceName='messaging4transport-default'} at org.opendaylight.controller.config.spi.AbstractModule.getInstance(AbstractModule.java:83) |
| Comments |
| Comment by Jamo Luhrsen [ 27/Oct/15 ] |
|
moving this bug to controller project as I noticed the exceptions are coming from "controller.config-manager", The first exception was what is seen on the karaf console. the karaf.log file has a little more, and most 2015-10-27 14:16:36,071 | ERROR | config-pusher | ConfigTransactionControllerImpl | 116 - org.opendaylight.controller.config-manager - 0.4.0.SNAPSHOT | Commit failed on ModuleIdentifier {factoryName='messaging4transport', instanceName='messaging4transport-default'} in transaction TransactionIdentifier{name='ConfigTransaction-234-236'}java.lang.IllegalStateException: Error in createInstance - null is not allowed as return value. Module: ModuleIdentifier{factoryName='messaging4transport', instanceName='messaging4transport-default'} at org.opendaylight.controller.config.spi.AbstractModule.getInstance(AbstractModule.java:83) at org.opendaylight.controller.config.manager.impl.ConfigTransactionControllerImpl.secondPhaseCommit(ConfigTransactionControllerImpl.java:427) at org.opendaylight.controller.config.manager.impl.ConfigRegistryImpl.secondPhaseCommit(ConfigRegistryImpl.java:280) at org.opendaylight.controller.config.manager.impl.ConfigRegistryImpl.commitConfig(ConfigRegistryImpl.java:227) at sun.reflect.GeneratedMethodAccessor52.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_60] at java.lang.reflect.Method.invoke(Method.java:497)[:1.8.0_60] at sun.reflect.misc.Trampoline.invoke(MethodUtil.java:71)[:1.8.0_60] at sun.reflect.GeneratedMethodAccessor33.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)[:1.8.0_60] at java.lang.reflect.Method.invoke(Method.java:497)[:1.8.0_60] at sun.reflect.misc.MethodUtil.invoke(MethodUtil.java:275)[:1.8.0_60] at com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:193)[:1.8.0_60] at com.sun.jmx.mbeanserver.ConvertingMethod.invokeWithOpenReturn(ConvertingMethod.java:175)[:1.8.0_60] at com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:117)[:1.8.0_60] at com.sun.jmx.mbeanserver.MXBeanIntrospector.invokeM2(MXBeanIntrospector.java:54)[:1.8.0_60] at com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)[:1.8.0_60] at com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)[:1.8.0_60] at com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)[:1.8.0_60] at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:819)[:1.8.0_60] at com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)[:1.8.0_60] at com.sun.jmx.mbeanserver.MXBeanProxy$InvokeHandler.invoke(MXBeanProxy.java:150)[:1.8.0_60] at com.sun.jmx.mbeanserver.MXBeanProxy.invoke(MXBeanProxy.java:167)[:1.8.0_60] at javax.management.MBeanServerInvocationHandler.invoke(MBeanServerInvocationHandler.java:258)[:1.8.0_60] at com.sun.proxy.$Proxy23.commitConfig(Unknown Source)[108:org.opendaylight.controller.config-api:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.util.ConfigRegistryJMXClient.commitConfig(ConfigRegistryJMXClient.java:110)[112:org.opendaylight.controller.config-util:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.facade.xml.transactions.TransactionProvider.commitTransaction(TransactionProvider.java:145)[118:org.opendaylight.controller.config-manager-facade-xml:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.facade.xml.ConfigSubsystemFacade.commitSilentTransaction(ConfigSubsystemFacade.java:138)[118:org.opendaylight.controller.config-manager-facade-xml:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.pushConfig(ConfigPusherImpl.java:292)[120:org.opendaylight.controller.config-persister-impl:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.pushConfigWithConflictingVersionRetries(ConfigPusherImpl.java:144)[120:org.opendaylight.controller.config-persister-impl:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.internalPushConfigs(ConfigPusherImpl.java:114)[120:org.opendaylight.controller.config-persister-impl:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.processSingle(ConfigPusherImpl.java:81)[120:org.opendaylight.controller.config-persister-impl:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.persist.impl.ConfigPusherImpl.process(ConfigPusherImpl.java:74)[120:org.opendaylight.controller.config-persister-impl:0.4.0.SNAPSHOT] at org.opendaylight.controller.config.persist.impl.osgi.ConfigPersisterActivator$2.run(ConfigPersisterActivator.java:131)[120:org.opendaylight.controller.config-persister-impl:0.4.0.SNAPSHOT] at java.lang.Thread.run(Thread.java:745)[:1.8.0_60] Caused by: java.lang.IllegalStateException: Error in createInstance - null is not allowed as return value. Module: ModuleIdentifier{factoryName='messaging4transport', instanceName='messaging4transport-default'} at org.opendaylight.controller.config.spi.AbstractModule.getInstance(AbstractModule.java:83) |
| Comment by Jamo Luhrsen [ 27/Oct/15 ] |
|
Actually, now I do see that something similar is happening in upstream CSIT however, in those logs I don't see anything about messaging4transport, but I do see unimgr-default: 2015-10-27 21:02:45,737 | ERROR | config-pusher | ConfigRegistryImpl | 89 - org.opendaylight.controller.config-manager - 0.4.0.SNAPSHOT | Configuration Transaction failed on 2PC, server is unhealthy in transaction TransactionIdentifier {name='ConfigTransaction-268-270'} at org.opendaylight.controller.config.manager.impl.ConfigTransactionControllerImpl.secondPhaseCommit(ConfigTransactionControllerImpl.java:427) |
| Comment by Robert Varga [ 27/Oct/15 ] |
|
The first stack trace seems to indicate that Messaging4TransportModule.getInstance() returned null – which is a breach of API contract, as it should be returning a live instance or throw an exception (as a last resort). Looking at that method there is some commented-out code. The second stack trace is a problem in unimgr, whose VcpeModule.getInstance() is not implemented at all – there is just a TODO and the throw. Can you split create individual bugs for those projects and link them here as dependencies, please? |
| Comment by Robert Varga [ 28/Oct/15 ] |
|
Moving to integration for tracking, as this is not a problem in config, but rather in the projects being pulled in. Also linked 4539 which seems to be related to the console output seen after installation. |
| Comment by Alexis de Talhouƫt [ 28/Oct/15 ] |
|
I don't know if there is already a BUG open for the unimgr, but I believe this will fix the issue: https://git.opendaylight.org/gerrit/#/c/28887/ Thanks, |
| Comment by Vratko Polak [ 16/Nov/15 ] |
|
Is this still happening? P.S.: Component "Distrubtion" has two typos, not just one, right? |
| Comment by Pradeeban Kathiravelu [ 03/Dec/15 ] |
|
On behalf of Messaging4Transport: I was in a vacation, and missed these reports. Assigning this back to me. |
| Comment by Pradeeban Kathiravelu [ 03/Dec/15 ] |
|
Must have been fixed with https://git.opendaylight.org/gerrit/#/c/30574/. Please reopen if the bug still appears/re-appears. |