[INTDIST-92] odl-distribution-version compiled feature contains list of bundles instead of nice feature dependency Created: 20/Sep/17  Updated: 21/Mar/18  Resolved: 21/Mar/18

Status: Resolved
Project: integration-distribution
Component/s: Codebase, Version
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Vratko Polak Assignee: Vratko Polak
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 9189

 Description   

Current feature pom dependency segment:
<dependencies>
<!-- Version module jar and config. -->
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>version</artifactId>
</dependency>
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>version</artifactId>
<type>xml</type>
<classifier>config</classifier>
</dependency>
<!-- External single feature dependencies. -->
<dependency>
<groupId>org.opendaylight.controller</groupId>
<artifactId>odl-config-persister</artifactId>
<type>xml</type>
<classifier>features</classifier>
</dependency>
</dependencies>

Current compiler feature dependency segment:
<feature name="odl-distribution-version" description="ODL :: integration :: odl-distribution-version" version="0.7.0.SNAPSHOT">
<details>Single feature for Version functionality.</details>
<configfile finalname="etc/opendaylight/karaf/odl-version.xml">
mvn:org.opendaylight.integration/version/0.7.0-SNAPSHOT/xml/config
</configfile>
<feature version="0.7.0.SNAPSHOT" prerequisite="false" dependency="false">odl-config-persister</feature>
<feature prerequisite="true" dependency="false">wrap</feature>
<bundle>mvn:org.opendaylight.integration/version/0.7.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-binding-config/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-binding-api/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-common-api/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-dom-config/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-core-api/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-dom-api/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-core-spi/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-dom-spi/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-singleton-dom-impl/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-common-api/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-eos-dom-api/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-eos-common-api/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-singleton-common-api/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-binding-broker-impl/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-binding-util/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-broker-impl/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:com.lmax/disruptor/3.3.6</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-dom-broker/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal/mdsal-dom-inmemory-datastore/2.3.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-inmemory-datastore/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-common-impl/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.controller/sal-common-util/1.6.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal.model/ietf-yang-types-20130715/2013.07.15.11.0-SNAPSHOT</bundle>
<bundle>mvn:org.opendaylight.mdsal.model/ietf-type-util/1.2.0-SNAPSHOT</bundle>
</feature>

The reason is that config-parent adds more dependencies (mainly controller:sal-binding-config) which need to be included in feature definition somehow.

 Comments   
Comment by Vratko Polak [ 20/Sep/17 ]

Contributed [0] for controller master branch. Another contribution will be needed for Integration/Distribution and perhaps also to Releng/Autorelease to make validate/autorelease pass.

[0] https://git.opendaylight.org/gerrit/63329

Comment by Vratko Polak [ 20/Sep/17 ]

> Another contribution will be needed for Integration/Distribution

[1].

> and perhaps also to Releng/Autorelease
> to make validate/autorelease pass.

[2].

If that goes to master, I will cherry-pick to stable/nitrogen.
Especially the controller change cannot be cherry-picked automatically, as it adds new files and versions do change between branches.

[1] https://git.opendaylight.org/gerrit/63331
[2] https://git.opendaylight.org/gerrit/63330

Comment by Vratko Polak [ 06/Nov/17 ]

Both bug_* log files from resent distribution check job run [3] confirm Int/Dist generated features no longer refer bundles from other projects.

[3] https://logs.opendaylight.org/releng/jenkins092/distribution-check-oxygen/72/

Comment by Luis Gomez [ 21/Mar/18 ]

I think this is fixed now, open in case it is not.

Generated at Wed Feb 07 20:02:44 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.