[INTPAK-104] Fix tox-verify triggering for all branches Created: 29/Nov/17 Updated: 22/Jan/18 Resolved: 22/Jan/18 |
|
| Status: | Closed |
| Project: | integration-packaging |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Medium |
| Reporter: | Daniel Farrell | Assignee: | Daniel Farrell |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
Int/Pack's main repo only has a master branch. However, changes are triggering tox-verify jobs for all branches.
https://git.opendaylight.org/gerrit/#/c/66038 First thoughts are that this is related to the change to tox-verify job from global-jjb. https://git.opendaylight.org/gerrit/#/c/64537/2/jjb/packaging/packaging.yaml |
| Comments |
| Comment by Daniel Farrell [ 15/Dec/17 ] |
|
This is still going on, for example: https://git.opendaylight.org/gerrit/#/c/66498/ |
| Comment by Daniel Farrell [ 15/Dec/17 ] |
|
Looking at lf-python-jobs.[yaml,rst] in global-jjb, it seems like it's meant to only trigger against master stream by default. |
| Comment by Daniel Farrell [ 15/Dec/17 ] |
|
I guess since we're declaring other streams for our project (used by some jobs) they are being picked up. |
| Comment by Daniel Farrell [ 15/Dec/17 ] |
|
I tried going back to what we had before and similar with no luck |
| Comment by Daniel Farrell [ 15/Dec/17 ] |
|
I asked about it on integration-dev: https://lists.opendaylight.org/pipermail/integration-dev/2017-December/010670.html |
| Comment by Thanh Ha (zxiiro) [ 19/Jan/18 ] |
|
Sorry looks like this one was my fault. This was introduced by this patch: https://github.com/opendaylight/releng-builder/commit/66c2bf6fbbbd4049cb106c1d122b4af632c32328 So it was caused by the migration to global-jjb. Packaging previously only ran tox against the master branch so the change introduced a version of tox job that supports multiple streams. Since the packaging yaml file contains a variable "branch: master" [0] it created 3 streams jobs all watching branch master for changes which explains why we see 3 copies of the same job running on every merge. This patch should get things back to how they were by forcing stream and branch for the tox-verify job to be master only: https://git.opendaylight.org/gerrit/67322 |
| Comment by Daniel Farrell [ 22/Jan/18 ] |
|
Awesome, thanks Thanh! Verified fixes with the last verify run on this patch. |