[INTTEST-30] Netconf session crash: "configuration is missing mandatory descendant" Created: 25/Jan/16  Updated: 19/Oct/17  Resolved: 26/Jan/16

Status: Resolved
Project: integration-test
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Jozef Behran Assignee: Jozef Behran
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


 Description   

Tested on: stable/beryllium

The Netconf MDSAL Northbound test suite fails at test case Commit_Multiple_Modules_Merge_Replace with the following error:

2016-01-25 16:54:33,920 | WARN | lt-dispatcher-42 | ConcurrentDOMDataBroker | 143 - org.opendaylight.controller.sal-distributed-datastore - 1.3.0.SNAPSHOT | Tx: DOM-31 Error during phase CAN_COMMIT, starting Abort
java.lang.IllegalArgumentException: Node (urn:opendaylight:params:xml:ns:yang:controller:config?revision=2013-04-05)configuration is missing mandatory descendant /(urn:opendaylight:params:xml:ns:yang:controller:md:sal:connector:netconf?revision=2015-08-03)dom-registry/name
at com.google.common.base.Preconditions.checkArgument(Preconditions.java:145)[39:com.google.guava:18.0.0]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.MandatoryLeafEnforcer$Strict.enforceOnTreeNode(MandatoryLeafEnforcer.java:58)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.CaseEnforcer.enforceOnTreeNode(CaseEnforcer.java:60)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.ChoiceModificationStrategy.enforceCases(ChoiceModificationStrategy.java:113)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.ChoiceModificationStrategy.verifyStructure(ChoiceModificationStrategy.java:85)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.verifyStructure(AbstractNodeContainerModificationStrategy.java:54)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.verifyStructure(AbstractNodeContainerModificationStrategy.java:54)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.MinMaxElementsValidation.verifyStructure(MinMaxElementsValidation.java:175)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractNodeContainerModificationStrategy.verifyStructure(AbstractNodeContainerModificationStrategy.java:54)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.StructuralContainerModificationStrategy.verifyStructure(StructuralContainerModificationStrategy.java:103)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.ModifiedNode.seal(ModifiedNode.java:284)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractReadyIterator.process(AbstractReadyIterator.java:45)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.yangtools.yang.data.impl.schema.tree.InMemoryDataTreeModification.ready(InMemoryDataTreeModification.java:280)[59:org.opendaylight.yangtools.yang-data-impl:0.8.0.SNAPSHOT]
at org.opendaylight.controller.sal.core.spi.data.SnapshotBackedWriteTransaction.ready(SnapshotBackedWriteTransaction.java:139)[115:org.opendaylight.controller.sal-core-spi:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.LocalTransactionFactoryImpl.onTransactionReady(LocalTransactionFactoryImpl.java:84)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.LocalTransactionContext.ready(LocalTransactionContext.java:74)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.LocalTransactionContext.directCommit(LocalTransactionContext.java:85)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.TransactionProxy.getReadyOrDirectCommitFuture(TransactionProxy.java:275)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.TransactionProxy.createSingleCommitCohort(TransactionProxy.java:261)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.TransactionProxy.ready(TransactionProxy.java:228)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.TransactionProxy.ready(TransactionProxy.java:52)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.submit(AbstractDOMBrokerWriteTransaction.java:134)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.netconf.mdsal.connector.TransactionProvider.commitTransaction(TransactionProvider.java:81)[256:org.opendaylight.netconf.mdsal-netconf-connector:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.mdsal.connector.ops.Commit.handleWithNoSubsequentOperations(Commit.java:39)[256:org.opendaylight.netconf.mdsal-netconf-connector:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.util.mapping.AbstractSingletonNetconfOperation.handle(AbstractSingletonNetconfOperation.java:26)[239:org.opendaylight.netconf.util:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.util.mapping.AbstractNetconfOperation.handle(AbstractNetconfOperation.java:101)[239:org.opendaylight.netconf.util:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.osgi.NetconfOperationRouterImpl$NetconfOperationExecution.execute(NetconfOperationRouterImpl.java:182)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.osgi.NetconfOperationRouterImpl.executeOperationWithHighestPriority(NetconfOperationRouterImpl.java:111)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.osgi.NetconfOperationRouterImpl.onNetconfMessage(NetconfOperationRouterImpl.java:84)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.NetconfServerSessionListener.processDocument(NetconfServerSessionListener.java:113)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.NetconfServerSessionListener.onMessage(NetconfServerSessionListener.java:86)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.NetconfServerSessionListener.onMessage(NetconfServerSessionListener.java:29)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.nettyutil.AbstractNetconfSession.handleMessage(AbstractNetconfSession.java:64)[240:org.opendaylight.netconf.netty-util:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.nettyutil.AbstractNetconfSession.handleMessage(AbstractNetconfSession.java:35)[240:org.opendaylight.netconf.netty-util:1.0.0.SNAPSHOT]
at org.opendaylight.protocol.framework.AbstractProtocolSession.channelRead0(AbstractProtocolSession.java:53)[231:org.opendaylight.controller.protocol-framework:0.7.0.SNAPSHOT]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)[103:io.netty.transport:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:276)[104:io.netty.codec:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:263)[104:io.netty.codec:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)[103:io.netty.transport:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:276)[104:io.netty.codec:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:354)[104:io.netty.codec:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:244)[104:io.netty.codec:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.local.LocalChannel.finishPeerRead0(LocalChannel.java:427)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.local.LocalChannel.access$500(LocalChannel.java:48)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:383)[103:io.netty.transport:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:358)[102:io.netty.common:4.0.33.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)[103:io.netty.transport:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:112)[102:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)[102:io.netty.common:4.0.33.Final]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_85]

After that any other operation on that session will fail with the following error:

2016-01-25 16:54:34,257 | ERROR | oupCloseable-3-7 | NetconfOperationRouterImpl | 246 - org.opendaylight.netconf.impl - 1.0.0.SNAPSHOT | Unexpected exception during netconf operation execution
java.lang.IllegalStateException: Transaction DOM-31 is no longer running
at com.google.common.base.Preconditions.checkState(Preconditions.java:197)[39:com.google.guava:18.0.0]
at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.checkRunning(AbstractDOMBrokerWriteTransaction.java:143)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.delete(AbstractDOMBrokerWriteTransaction.java:87)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.controller.cluster.databroker.AbstractDOMBrokerWriteTransaction.delete(AbstractDOMBrokerWriteTransaction.java:35)[143:org.opendaylight.controller.sal-distributed-datastore:1.3.0.SNAPSHOT]
at org.opendaylight.netconf.mdsal.connector.ops.EditConfig.executeChange(EditConfig.java:135)[256:org.opendaylight.netconf.mdsal-netconf-connector:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.mdsal.connector.ops.EditConfig.executeOperations(EditConfig.java:98)[256:org.opendaylight.netconf.mdsal-netconf-connector:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.mdsal.connector.ops.EditConfig.handleWithNoSubsequentOperations(EditConfig.java:85)[256:org.opendaylight.netconf.mdsal-netconf-connector:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.util.mapping.AbstractSingletonNetconfOperation.handle(AbstractSingletonNetconfOperation.java:26)[239:org.opendaylight.netconf.util:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.util.mapping.AbstractNetconfOperation.handle(AbstractNetconfOperation.java:101)[239:org.opendaylight.netconf.util:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.osgi.NetconfOperationRouterImpl$NetconfOperationExecution.execute(NetconfOperationRouterImpl.java:182)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.osgi.NetconfOperationRouterImpl.executeOperationWithHighestPriority(NetconfOperationRouterImpl.java:111)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.osgi.NetconfOperationRouterImpl.onNetconfMessage(NetconfOperationRouterImpl.java:84)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.NetconfServerSessionListener.processDocument(NetconfServerSessionListener.java:113)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.NetconfServerSessionListener.onMessage(NetconfServerSessionListener.java:86)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.impl.NetconfServerSessionListener.onMessage(NetconfServerSessionListener.java:29)[246:org.opendaylight.netconf.impl:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.nettyutil.AbstractNetconfSession.handleMessage(AbstractNetconfSession.java:64)[240:org.opendaylight.netconf.netty-util:1.0.0.SNAPSHOT]
at org.opendaylight.netconf.nettyutil.AbstractNetconfSession.handleMessage(AbstractNetconfSession.java:35)[240:org.opendaylight.netconf.netty-util:1.0.0.SNAPSHOT]
at org.opendaylight.protocol.framework.AbstractProtocolSession.channelRead0(AbstractProtocolSession.java:53)[231:org.opendaylight.controller.protocol-framework:0.7.0.SNAPSHOT]
at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:105)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)[103:io.netty.transport:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:276)[104:io.netty.codec:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:263)[104:io.netty.codec:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)[103:io.netty.transport:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.fireChannelRead(ByteToMessageDecoder.java:276)[104:io.netty.codec:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:354)[104:io.netty.codec:4.0.33.Final]
at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:244)[104:io.netty.codec:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:318)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:304)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:846)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.local.LocalChannel.finishPeerRead0(LocalChannel.java:427)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.local.LocalChannel.access$500(LocalChannel.java:48)[103:io.netty.transport:4.0.33.Final]
at io.netty.channel.local.LocalChannel$5.run(LocalChannel.java:383)[103:io.netty.transport:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:358)[102:io.netty.common:4.0.33.Final]
at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:357)[103:io.netty.transport:4.0.33.Final]
at io.netty.util.concurrent.SingleThreadEventExecutor$2.run(SingleThreadEventExecutor.java:112)[102:io.netty.common:4.0.33.Final]
at io.netty.util.concurrent.DefaultThreadFactory$DefaultRunnableDecorator.run(DefaultThreadFactory.java:137)[102:io.netty.common:4.0.33.Final]
at java.lang.Thread.run(Thread.java:745)[:1.7.0_85]

I am not sure whether the condition survives session cycling as the test suite does not check that.

 Comments   
Comment by Jozef Behran [ 26/Jan/16 ]

Most likely a bug in the test suite. Check the data used by the suite and fix them.

Comment by Vratko Polak [ 26/Jan/16 ]

Check netconf git repository, opendaylight/netconf/sal-netconf-connector/src/main/yang/odl-sal-netconf-connector-cfg.yang file to see which fields are required for 'sal-netconf-connector' type configuration case.
The same repository contains example values in opendaylight/netconf/netconf-connector-config/src/main/resources/initial/99-netconf-connector.xml

Most likely, Lithium suite would need different data than Beryllium suite.
Perhaps better idea would be to use different schema, as config subsystem interprets models in a slightly different way than MDSAL. I recommend cars/people models from controller repository, opendaylight/md-sal/samples/clustering-test-app/model/src/main/yang/ directory.

On the other hand, failure of subsequent operations is a Bug, "Transaction DOM-31 is no longer running" should not happen just because user sent invalid data.
So this should be split into two Bugs.

Comment by Jozef Behran [ 26/Jan/16 ]

Splitted into INTEGRAT-50 NETCONF-132 and NETCONF-133.

Generated at Wed Feb 07 20:04:22 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.