clean up and update yang-model-validator suite (INTTEST-75)

[INTTEST-79] try to resolve yang syntax issues in public yang models Created: 30/Mar/20  Updated: 03/Apr/20  Resolved: 03/Apr/20

Status: Resolved
Project: integration-test
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Sub-task Priority: Medium
Reporter: Jamo Luhrsen Assignee: Jamo Luhrsen
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

CSIT is pulling this yang github repo to run the
validator. The repo has a lot of syntax issues, most of which can be resolved with simple
edits (adding semicolons, etc). One of the trickier issues is how to handle this:

/* Mapped to device model
 *     Device Model Target: /top:System/top:rpm-items/top:pfxlistv4-items/top:RuleV4-list/top:name
 * Transformation Function: oc_prefix_name_to_rule_prefix_name
 */
  deviation oc-rpol:routing-policy/oc-rpol:defined-sets/oc-rpol:prefix-sets/oc-rpol:prefix-set/oc-rpol:prefix-set-name {
    deviate /* add, replace, or delete */ {
      /* something */ /* "something's value" */;
    }
  }

the deviate statement does not pass validation.

 Comments   
Comment by Jamo Luhrsen [ 31/Mar/20 ]

I have the edits needed for the https://github.com/YangModels/yang repo in the experimental/ folder. I asked a
question on github (via [PR | https://github.com/YangModels/yang/issues/806]) if I can just contribute those via pull request.

but, there is at least one other issue in the vendor/cisco subdir that I noted in the description. Also, those files
have a header indicating that they are auto-generated, so I do not know how to get those changed/fixed. If we
can't find a way to fix the yang models, then we can update the test to remove those files before running the
test. That's not ideal though

Comment by Jamo Luhrsen [ 03/Apr/20 ]

I closed my github issue after learning how things work. This is not going to happen unless the owners of those
broken models do the work to fix it. And even if everything was fixed right now, there is no stopping some new
update to that repo to come in with broken yang which would then break our CSIT if we are using HEAD of
master for every job.

Now I understand why the original test was freezing the repo at a specific commit and then removing a bunch
of specific files and folders.

I am currently updating the test code to update to a recent commit so we wont be testing against something
so old.

Generated at Wed Feb 07 20:04:31 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.