[L2SWITCH-25] L2switch sample fails to handle topology updates, uses deprecated APIs Created: 28/Oct/14  Updated: 30/Oct/17  Resolved: 27/Apr/16

Status: Resolved
Project: l2switch
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: James Gregory Hall Assignee: James Gregory Hall
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 2263

 Description   

When updated and original data are equal, but new data nodes are created ... TopologyDataChangeHandler's onDataChanged doesn't properly schedule a topology update.

if(linkOriginalData != null && linkUpdatedData != null
&& (linkOriginalData.size() != 0 || linkUpdatedData.size() != 0)
&& !networkGraphRefreshScheduled) {
networkGraphRefreshScheduled = linkOriginalData.size() != linkUpdatedData.size();
if(networkGraphRefreshScheduled)

{ networkGraphRefreshScheduler.schedule(new NetworkGraphRefresher(), graphRefreshDelayInSec, TimeUnit.SECONDS); }
}

This needs to be modified to use change.getCreatedOperationalData() and handle the case where only created nodes exist.


Map<InstanceIdentifier<?>, DataObject> linkCreatedData = dataChangeEvent.getCreatedOperationalData();
// change this logic, once MD-SAL start populating DeletedOperationData Set
if(linkOriginalData != null && linkUpdatedData != null && linkCreatedData != null
&& (linkOriginalData.size() != 0 || linkUpdatedData.size() != 0 || linkCreatedData.size() != 0)
&& !networkGraphRefreshScheduled) {
networkGraphRefreshScheduled = true;
if(networkGraphRefreshScheduled) { networkGraphRefreshScheduler.schedule(new NetworkGraphRefresher(), graphRefreshDelayInSec, TimeUnit.SECONDS); }

}

 Comments   
Comment by Tony Tkacik [ 07/Apr/15 ]

Are you still working on this bug?

Comment by Carol Sanders [ 04/May/15 ]

This bug is part of the project to Move all ADSAL associated component bugs to ADSAL

Comment by Abhijit Kumbhare [ 25/Jan/16 ]

Is this bug still present?

Comment by Abhijit Kumbhare [ 30/Jan/16 ]

Moving bug to L2 switch.

Comment by A H [ 02/Feb/16 ]

Adding ammandke@cisco.com. Amit Mandke, any insights you can share? Is this bug still critical?

Comment by Sai MarapaReddy [ 19/Apr/16 ]

Above mentioned code is not part of l2switch code base.

Please let me know in other case.

Generated at Wed Feb 07 20:05:43 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.