[L2SWITCH-37] Missing ID for IEEE standard 802.1ad Created: 18/Mar/15 Updated: 19/Oct/17 Resolved: 09/Sep/15 |
|
| Status: | Resolved |
| Project: | l2switch |
| Component/s: | General |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Anton Ivanov | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 2865 |
| Description |
|
The yang definitions for Ethernet packet have only the (mostly) Cisco specific Q-n-Q nested tag definition. This is a pre-standard form for provider bridging, the standard is different. As a result, this will not work versus Linux and may or may not work versus white box silicon and other vendors which comply to the Ethernet 802.1ad standard as specified in 802.1ad. The yang model should also include the ad tag for nested vlans - 0x88a8. |
| Comments |
| Comment by Anton Ivanov [ 29/Jun/15 ] |
|
After re-reading the model, this is a bit more convoluted. 1. There is an ethertype for 802.1ad mentioned in the yang model, however it is not in use. It is not part of the header8021q-type definition. 2. header8021q-type misses the mentioning of 802.1ad ethertype 3. The model is too weak - it does not enforce header field order. 3.1. The first header is either a 802.1ad or 802.1q. If it is 802.1q there are no subsequent headers 4. The partial easy fix is to add 802.1ad to the enum - this will enable it in the packet handler. I will submit a patch to that effect shortly. 5. We need to tighten up the model a bit in order for builders, etc to function correctly and as expected (based on model) by the consumers. |
| Comment by Anton Ivanov [ 09/Sep/15 ] |
|
Partial fix. The yang model is too lose to enforce some of the finer points of Ethernet header ordering so we only allow the correct header type here. We do not limit it to perform ordering checks (f.e. - 802.1q can presently be insterted before an ad header which is an incorrect combination). |