[L2SWITCH-50] l2switch/arphandler/core/PacketDispatcher.java line 102: Wrong in_port in PacketOut message Created: 08/Jul/15  Updated: 19/Oct/17  Resolved: 08/Sep/15

Status: Resolved
Project: l2switch
Component/s: General
Affects Version/s: unspecified
Fix Version/s: None

Type: Bug
Reporter: Sudeep Kumar Singh Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: Linux
Platform: PC


External issue ID: 3958
Priority: Normal

 Description   

As per OpenFlow Spec 1.3 section A.3.7 Packet-Out Message:

uint32_t in_port; /* Packet's input port or OFPP_CONTROLLER. */

But floodPacket function at l2switch/arphandler/core/PacketDispatcher.java line 102 sets in_port as controllerNodeConnector which in turns sets OFPP_LOCAL instead of input port or OFPP_CONTROLLER.

Solution:
change sendPacketOut(payload, controllerNodeConnector, ncRef);

to

sendPacketOut(payload, origIngress, ncRef);

which will set input port.



 Comments   
Comment by Anton Ivanov [ 07/Sep/15 ]

Gerrit:

https://git.opendaylight.org/gerrit/26588

Agree, the port should be set to origIngress.

This is not just openflow spec, it is the way switch software works in general.

Comment by Anton Ivanov [ 08/Sep/15 ]

Fixed in master

Generated at Wed Feb 07 20:05:47 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.