[L2SWITCH-69] Fix checkstyle invocation for l2switch builds Created: 01/Apr/16 Updated: 14/Apr/16 Resolved: 14/Apr/16 |
|
| Status: | Resolved |
| Project: | l2switch |
| Component/s: | General |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Ajay L | Assignee: | Ajay L |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 5644 |
| Description |
|
I pushed a change to l2switch project recently (https://git.opendaylight.org/gerrit/#/c/35300/) which accidentally had tabs in it. The build went through fine without checkstyle complaining about it (on other projects e.g. bgpcep, build would fail) Looks like l2switch is setup to use checkstyle during build, but it has got broken. Opening this bug to get it fixed |
| Comments |
| Comment by Ajay L [ 04/Apr/16 ] |
|
I was hoping that this would entail enabling checkstyle and most of existing code will already be complaint. But looks like checkstyle was not running for a while and many of the code bits added since then are non-complaint. I have fixed all warnings reported. The changeset is pretty big but this would be a one-off change and hopefully will increase the consistency, readability and maintainability of code. Going forward having checkstyle enabled will ensure compliance for new/modified code that will get added |
| Comment by Ajay L [ 04/Apr/16 ] |
|
Pull request - https://git.opendaylight.org/gerrit/#/c/37027 |