[LISPMAP-143] boron autorelease failing on lispflowmapping tests Created: 26/Oct/16  Updated: 19/Oct/17  Resolved: 01/Nov/16

Status: Resolved
Project: lispflowmapping
Component/s: General
Affects Version/s: Boron
Fix Version/s: None

Type: Bug
Reporter: Anil Belur Assignee: Unassigned
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 7035
Priority: Highest

 Description   

We have the boron autorelease failing on lispflowmapping tests, please refer to the logs in [1.] and summary of the failure [2.]

[1.] https://logs.opendaylight.org/releng/jenkins092/autorelease-release-boron/48/_console-output.log.gz

[2.]
04:47:42 [INFO] Mapping Service Inmemory Mappings Database ......... FAILURE [ 1.702 s]

04:47:42 [INFO] — maven-surefire-plugin:2.18.1:test (default-test) @ mappingservice.inmemorydb —
04:47:42 [INFO] Surefire report directory: /w/workspace/autorelease-release-boron/lispflowmapping/mappingservice/inmemorydb/target/surefire-reports
04:47:42
04:47:42 -------------------------------------------------------
04:47:42 T E S T S
04:47:42 -------------------------------------------------------
04:47:42 Running org.opendaylight.lispflowmapping.inmemorydb.radixtrie.RadixTrieRandomIpTest
04:47:42 Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.071 sec - in org.opendaylight.lispflowmapping.inmemorydb.radixtrie.RadixTrieRandomIpTest
04:47:42 Running org.opendaylight.lispflowmapping.inmemorydb.radixtrie.RadixTrieTest
04:47:42 Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 sec - in org.opendaylight.lispflowmapping.inmemorydb.radixtrie.RadixTrieTest
04:47:42 Running org.opendaylight.lispflowmapping.inmemorydb.HashMapDbTest
04:47:42 Tests run: 20, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.137 sec <<< FAILURE! - in org.opendaylight.lispflowmapping.inmemorydb.HashMapDbTest
04:47:42 testCleanOld(org.opendaylight.lispflowmapping.inmemorydb.HashMapDbTest) Time elapsed: 0.021 sec <<< FAILURE!
04:47:42 java.lang.AssertionError: Entry should not be present in the DB due to its time expired expected null, but was:<record2>
04:47:42 at org.junit.Assert.fail(Assert.java:88)
04:47:42 at org.junit.Assert.failNotNull(Assert.java:664)
04:47:42 at org.junit.Assert.assertNull(Assert.java:646)
04:47:42 at org.opendaylight.lispflowmapping.inmemorydb.HashMapDbTest.testCleanOld(HashMapDbTest.java:300)
04:47:42 at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
04:47:42 at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
04:47:42 at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
04:47:42 at java.lang.reflect.Method.invoke(Method.java:498)
04:47:42 at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
04:47:42 at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
04:47:42 at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
04:47:42 at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
04:47:42 at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
04:47:42 at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
04:47:42 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
04:47:42 at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
04:47:42 at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
04:47:42 at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
04:47:42 at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
04:47:42 at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
04:47:42 at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
04:47:42 at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
04:47:42 at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
04:47:42 at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
04:47:42 at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
04:47:42 at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
04:47:42 at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
04:47:42 at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
04:47:42 at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
04:47:42
04:47:42
04:47:42 Results :
04:47:42
04:47:42 Failed tests:
04:47:42 HashMapDbTest.testCleanOld:300 Entry should not be present in the DB due to its time expired expected null, but was:<record2>
04:47:42
04:47:42 Tests run: 29, Failures: 1, Errors: 0, Skipped: 0

 Comments   
Comment by Lori Jakab [ 26/Oct/16 ]

Can this be reliably reproduced?

I have seen this test failure show up every now and then, but occurrence is very rare, and wasn't able to track down the root case yet (since it's hard to reproduce).

Comment by Lori Jakab [ 26/Oct/16 ]

Fix proposed: https://git.opendaylight.org/gerrit/#/c/47588/

Comment by Lori Jakab [ 26/Oct/16 ]

And here is the patch cherry-picked to Boron: https://git.opendaylight.org/gerrit/#/c/47596/

Comment by A H [ 26/Oct/16 ]

A patch was submitted to fix this bug in Boron SR1: https://git.opendaylight.org/gerrit/#/c/47596/

To better assess the impact of this bug and fix, could someone from your team please help us identify the following:
Severity: This bug is blocking autorelease and must be fix.
Testing: Could you also elaborate on the testing of this patch? How extensively has this patch been tested? Is it covered by any unit tests or system tests?
Impact: Does this fix impact any dependent projects?

Comment by Lori Jakab [ 27/Oct/16 ]

(In reply to A H from comment #4)
> A patch was submitted to fix this bug in Boron SR1:
> https://git.opendaylight.org/gerrit/#/c/47596/
>
> To better assess the impact of this bug and fix, could someone from your
> team please help us identify the following:
> Severity: This bug is blocking autorelease and must be fix.

Since autorelease failed and the bug was reported as blocking, we handled it as such.

> Testing: Could you also elaborate on the testing of this patch? How
> extensively has this patch been tested? Is it covered by any unit tests or
> system tests?

The issue was a very rare race condition, it's impossible to test with certainty.

> Impact: Does this fix impact any dependent projects?

No impact on other projects.

Comment by A H [ 01/Nov/16 ]

Has this bug been verified as fixed in the latest Boron SR1 Build 20161030?

Comment by Lori Jakab [ 01/Nov/16 ]

(In reply to A H from comment #6)
> Has this bug been verified as fixed in the latest Boron SR1 Build 20161030?

I don't know how to test with 100% certainty, but I definitely didn't see the test failure again.

Generated at Wed Feb 07 20:06:36 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.