|
If this bug turns out to mean that all System.getProperty() calls need to be investigated. I've made a list of those by grepping for System.getProperty and removing false positives [0]. The result is that the following projects participating in Heluim have potential issues:
- Controller
- Defense4All
- Group Based Policy
- OpenFlowPlugin
- OVSDB
- Plugin to OpenContrail
- SDN Interface App
- SNBI
- SNMP4SDN
- VTN
- YANG Tools
Here are the files for each:
Controller
./opendaylight/clustering/services_implementation/src/main/java/org/opendaylight/controller/clustering/services_implementation/internal/ClusterManager.java
./opendaylight/config/logback-config-loader/src/main/java/org/opendaylight/controller/logback/config/loader/Activator.java
./opendaylight/configuration/api/src/main/java/org/opendaylight/controller/configuration/ConfigurationObject.java
./opendaylight/connectionmanager/implementation/src/main/java/org/opendaylight/controller/connectionmanager/internal/ConnectionManager.java
./opendaylight/containermanager/api/src/main/java/org/opendaylight/controller/containermanager/ContainerConfig.java
./opendaylight/distribution/sanitytest/src/main/java/org/opendaylight/controller/distribution/Sanity.java
./opendaylight/forwardingrulesmanager/implementation/src/main/java/org/opendaylight/controller/forwardingrulesmanager/internal/FlowEntryDistributionOrderFutureTask.java
./opendaylight/hosttracker/api/src/main/java/org/opendaylight/controller/hosttracker/HostIdFactory.java
./opendaylight/md-sal/sal-binding-broker/src/main/java/org/opendaylight/controller/sal/binding/codegen/impl/SingletonHolder.java
./opendaylight/md-sal/sal-distributed-datastore/src/main/java/org/opendaylight/controller/cluster/datastore/Shard.java
/src/main/java/org/opendaylight/controller/protocol_plugin/openflow/core/internal/Controller.java
./opendaylight/switchmanager/implementation/src/main/java/org/opendaylight/controller/switchmanager/internal/SwitchManager.java
Defense4All
./framework.core.impl/src/main/java/org/opendaylight/defense4all/framework/core/impl/FrameworkMainImpl.java
Group Based Policy
./groupbasedpolicy/src/main/java/org/opendaylight/groupbasedpolicy/renderer/opflex/OpflexConnectionService.java
OpenFlow Plugin
./openflow-protocol-impl/src/main/java/org/opendaylight/openflowjava/protocol/impl/core/SslKeyStore.java
OVSDB
./library/src/main/java/org/opendaylight/ovsdb/lib/impl/OvsdbConnectionService.java
./openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/ConfigurationServiceImpl.java
./openstack/net-virt/src/main/java/org/opendaylight/ovsdb/openstack/netvirt/impl/NeutronL3Adapter.java
./plugin/src/main/java/org/opendaylight/ovsdb/plugin/api/OvsVswitchdSchemaConstants.java
./plugin/src/main/java/org/opendaylight/ovsdb/plugin/impl/ConfigurationServiceImpl.java
./plugin/src/main/java/org/opendaylight/ovsdb/plugin/OvsVswitchdSchemaConstants.java
Plugin to OpenContrail
./neutron/src/main/java/org/opendaylight/plugin2oc/neutron/Activator.java
SDN Interface App
./sdniaggregator/src/main/java/org/opendaylight/controller/sdniaggregator/SdniManager.java
SNBI
./southplugin/src/main/java/org/opendaylight/snbi/southplugin/CertManagerConstants.java
SNMP4SDN
./snmp4sdn/src/main/java/org/opendaylight/snmp4sdn/core/internal/Controller.java
./snmp4sdn/src/main/java/org/opendaylight/snmp4sdn/core/internal/SwitchHandler.java
./snmp4sdn/src/main/java/org/opendaylight/snmp4sdn/internal/DiscoveryService.java
./snmp4sdn/src/main/java/org/opendaylight/snmp4sdn/internal/FlowProgrammerService.java
./snmp4sdn/src/main/java/org/opendaylight/snmp4sdn/internal/OFStatisticsManager.java
./third-party/expect4j/src/main/java/org/expect4j/ExpectEmulation.java
VTN
./coordinator/core/java/pfc_util/src/org/opendaylight/vtn/core/CoreSystem.java
./coordinator/core/java/pfc_util/src/org/opendaylight/vtn/core/util/Logger.java
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcDoubleTest.java
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/IpcFloatTest.java
./coordinator/core/test/java/pfc_ipc/src/org/opendaylight/vtn/core/ipc/TestBase.java
./coordinator/core/test/java/pfc_util/src/org/opendaylight/vtn/core/util/LoggerTest.java
./coordinator/core/test/java/pfc_util/src/org/opendaylight/vtn/core/util/TestBase.java
./coordinator/java/tomcat/unc-addon/src/org/opendaylight/vtn/tomcat/server/GlobalResourceManager.java
./manager/implementation/src/main/java/org/opendaylight/vtn/manager/internal/Activator.java
YangTools
./code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/util/DefaultSourceCodeGenerator.java
./code-generator/binding-generator-impl/src/main/java/org/opendaylight/yangtools/sal/binding/generator/util/SourceCodeGeneratorFactory.java
./common/util/src/main/java/org/opendaylight/yangtools/util/MapAdaptor.java
./common/util/src/main/java/org/opendaylight/yangtools/util/PropertyUtils.java
[0] I dropped the following things as false positives:
- SingleFeatureTest.java in all projects
- anything in a target or target-ide directory
- anything starting with the path ./opendaylight/protocol_plugins/openflow/
- anything with src/test in the path
|