[LISPMAP-5] Northbound doesn't allow priority and multicastPriority values to be set to 255 Created: 31/Jan/14 Updated: 10/Feb/14 Resolved: 10/Feb/14 |
|
| Status: | Resolved |
| Project: | lispflowmapping |
| Component/s: | General |
| Affects Version/s: | unspecified |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Lori Jakab | Assignee: | Sachi Gupta |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 399 |
| Description |
|
When trying to register a mapping using the northbound API, a values above 127 cause the following error: "Internal Error : There was an error while converting the map register". The yang model defines these fields as uint8, but they seem to be used as signed in the NB API. When a map-register packet with one of those fields set to 255 is sent, it is processed correctly by the southbound API, however, the northbound shows it as a signed integer: -1. Still input of signed integers is not accepted (setting priority to -1 gives the same error). |
| Comments |
| Comment by Sachi Gupta [ 07/Feb/14 ] |
|
Hi Lori Jakab, Please find the comments inline: 1. The variables priority and multicastPriority are declared as byte in NB API, so it ranges from -128 to 127 whereas they are declared as uint8 in yang modules, so it ranges from 0 to 255. 2. When a value(127 < value < 255) is used to register map, the NB API gives the "Internal Error : There was an error while converting the map register", because value is greater than its range but it is processed correctly by SB API since it is within its range. Proposed Solution: To maintain the same range for variables priority and multicastPriority in both the modules [NB API, Yang]. For this we have to convert the uint8(0-255) type declared in yang modules to int8(-128 to 127) as we can't make the change in the NB API as java doesn't support unassigned data type. Please update whether we should go ahead with this approach or not. |
| Comment by Sachi Gupta [ 10/Feb/14 ] |
|
Hi Lori Jakab, Fixed the bug. Please re-verify and test for the bug closure. Thanks |
| Comment by Sachi Gupta [ 10/Feb/14 ] |
|
Bug Fixed and merged. Check gerrit https://git.opendaylight.org/gerrit/#/c/5225/ |