[LISPMAP-60] ACT Flags are not set properly in Map-Reply Created: 14/Jul/15 Updated: 19/Oct/17 Resolved: 22/Jul/15 |
|
| Status: | Resolved |
| Project: | lispflowmapping |
| Component/s: | General |
| Affects Version/s: | Lithium |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Vina Ermagan | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 3995 |
| Priority: | High |
| Description |
|
ACT bits are not filled from DAO in Map-Reply, but they are set to default no action. Need to fix this to return the ACT bits stored in DAO. Same for Authoritative bit. |
| Comments |
| Comment by Lori Jakab [ 15/Jul/15 ] |
|
While looking at the source code in mappingservice/implementation/src/main/java/org/opendaylight/lispflowmapping/implementation/lisp/MapResolver.java lines 81 and 82 suggests that the action and authoritative bits are hardcoded to NoAction and False respectively, further inspection shows that those are only defaults, which are later overridden on lines 141 and 142, when locators are present, and line 114, when no locators are present. Testing confirmed that the correct value stored in DAO is returned both with RPC query on the northbound and using lig on the southbound. |
| Comment by Vina Ermagan [ 17/Jul/15 ] |
|
The issue seems to persist. The test to verify proper solution is to receive a NEGATIVE Map-Reply in lig with ACT set to DROP. |
| Comment by Lori Jakab [ 21/Jul/15 ] |
|
Fix proposed: https://git.opendaylight.org/gerrit/#/c/24330/ |