[LISPMAP-69] Attempting to send SMR to subscriber with null Source-EID causes exception Created: 05/Aug/15 Updated: 19/Oct/17 Resolved: 17/Aug/15 |
|
| Status: | Resolved |
| Project: | lispflowmapping |
| Component/s: | Service |
| Affects Version/s: | Lithium |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Lori Jakab | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 4097 |
| Description |
|
There are legitimate cases when a Map-Request does not contain a Source-EID, such as the standalone 'lig' utility, which shouldn't really be considered a subscriber to a mapping when it is run from a standalone host (as opposed to an xTR with a mapping cache). In this case it doesn't make sense to store the originator as a subscriber, and send SMRs on mapping changes, since there is no process listening for these control messages. The current code does store subscribers with no Source-EID, and attempts to send an SMR, but this results in an exception, since the Source-EID is now required (it wasn't previously). The correct behavior should be not to store subscribers without a Source-EID at all. |
| Comments |
| Comment by Lori Jakab [ 06/Aug/15 ] |
|
Fix proposed: https://git.opendaylight.org/gerrit/#/c/24827/ |
| Comment by Vina Ermagan [ 13/Aug/15 ] |
|
Should we close this? I see the fix is merged. |
| Comment by Lori Jakab [ 14/Aug/15 ] |
|
I'd like for someone other than me to to test the fix. |
| Comment by Florin Coras [ 17/Aug/15 ] |
|
I tested the fix and it works as expected. |