[MDSAL-148] auto generated code by YANGTOOLS could be more efficient (binding spec. v2) Created: 05/Apr/16 Updated: 09/Mar/18 Resolved: 18/May/17 |
|
| Status: | Resolved |
| Project: | mdsal |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Improvement | ||
| Reporter: | Martin Ciglan | Assignee: | Unassigned |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Issue Links: |
|
||||||||
| Description |
|
+++ This bug was initially created as a clone of I am reading the code under ALTO@ODL. And here are my two comments. 1:File named ‘AltoProviderImplBuilder’under alto-provider/……./modules/module/configuration :in function named 'toString',first is defined to judge a common should be inserted, i recommend writting as following @Override if (_dataBroker != null) { builder.append("_dataBroker="); builder.append(_dataBroker); builder.append(", ");//new added } if (_rpcRegistry != null) { //if (first) { // first = false; //} else { // builder.append(", "); //} builder.append("_rpcRegistry="); } else { // builder.append(", "); //} builder.append("augmentation="); BTW,could anyone tell me who is responsible for the improvements |
| Comments |
| Comment by Martin Ciglan [ 05/Apr/16 ] |
|
consider using Objects.toStringHelper |