[MDSAL-148] auto generated code by YANGTOOLS could be more efficient (binding spec. v2) Created: 05/Apr/16  Updated: 09/Mar/18  Resolved: 18/May/17

Status: Resolved
Project: mdsal
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Improvement
Reporter: Martin Ciglan Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All
URL: https://ask.opendaylight.org/question/3617/there-should-be-some-improvement-about-the-auto-generated-codes-from-yangtools/


Issue Links:
Blocks
is blocked by MDSAL-237 Milestone: Implement Binding Specific... Resolved

 Description   

+++ This bug was initially created as a clone of MDSAL-84 +++

I am reading the code under ALTO@ODL. And here are my two comments.

1:File named ‘AltoProviderImplBuilder’under alto-provider/……./modules/module/configuration :in function named 'toString',first is defined to judge a common should be inserted, i recommend writting as following

@Override
public java.lang.String toString() {
java.lang.StringBuilder builder = new java.lang.StringBuilder ("AltoProviderImpl [");
//boolean first = true;

if (_dataBroker != null) {
//if (first)

{ // first = false; //} else { // builder.append(", "); //}
builder.append("_dataBroker=");
builder.append(_dataBroker);
builder.append(", ");//new added

}
if (_rpcRegistry != null) {
//if (first) { // first = false; //}

else

{ // builder.append(", "); //}

builder.append("_rpcRegistry=");
builder.append(_rpcRegistry);
builder.append(", ");//new added

}
//if (first)

{ // first = false; //}

else

{ // builder.append(", "); //}

builder.append("augmentation=");
builder.append(augmentation.values());
return builder.append(']').toString();
}
}
Fewer judgement, fewer jumpes and simplified, consistent code,Make sense. There are similar something in file named RpcRegistryBuilder.java under alto-provider/……../modules/module/configuration/alto/provider/impl

BTW,could anyone tell me who is responsible for the improvements



 Comments   
Comment by Martin Ciglan [ 05/Apr/16 ]

consider using Objects.toStringHelper

Generated at Wed Feb 07 20:08:45 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.