[MDSAL-202] MDSAL Boron SR1 Autorelease Build Failure Created: 21/Oct/16  Updated: 09/Mar/18  Resolved: 23/Oct/16

Status: Resolved
Project: mdsal
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: A H Assignee: Robert Varga
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 7009
Priority: Highest

 Description   

There are Boron SR1 Autorelease Build Failures on mdsal binding jobs tests.

https://logs.opendaylight.org/releng/jenkins092/autorelease-release-boron/42/_console-output.log.gz

13:17:14 [INFO] *--- maven-surefire-plugin:2.18.1:test (default-test) @
mdsal-binding-java-api-generator — *13:17:14 [INFO] Surefire report directory: /w/workspace/autorelease-release-boron/mdsal/binding/mdsal-binding-java-api-generator/target/surefire-reports
13:17:21 Tests run: 13, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 2.765 sec <<< FAILURE! - in org.opendaylight.yangtools.sal.java.api.generator.test.CompilationTest
13:17:21 testGenerationContextReferenceExtension(org.opendaylight.yangtools.sal.java.api.generator.test.CompilationTest) Time elapsed: 0.027 sec <<< ERROR!
13:17:21 org.opendaylight.yangtools.yang.parser.spi.meta.SomeModifiersUnresolvedException: Some of FULL_DECLARATION modifiers for statements were not resolved.
13:17:21 at org.opendaylight.yangtools.yang.parser.spi.source.SourceException.throwIf(SourceException.java:96)
13:17:21 at org.opendaylight.yangtools.yang.parser.stmt.reactor.ContextBuilder.setArgument(ContextBuilder.java:34)
13:17:21 at org.opendaylight.yangtools.yang.parser.stmt.reactor.StatementContextWriter.argumentValue(StatementContextWriter.java:40)
13:17:21 at org.opendaylight.yangtools.yang.parser.impl.YangStatementParserListenerImpl.enterStatement(YangStatementParserListenerImpl.java:84)
13:17:21 at org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser$StatementContext.enterRule(YangStatementParser.java:113)
13:17:21 at org.antlr.v4.runtime.tree.ParseTreeWalker.enterRule(ParseTreeWalker.java:66)
13:17:21 at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:49)
13:17:21 at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)
13:17:21 at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)
13:17:21 at org.antlr.v4.runtime.tree.ParseTreeWalker.walk(ParseTreeWalker.java:52)
13:17:21 at org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YangStatementSourceImpl.writeFull(YangStatementSourceImpl.java:98)
13:17:21 at org.opendaylight.yangtools.yang.parser.stmt.reactor.SourceSpecificContext.loadStatements(SourceSpecificContext.java:321)
13:17:21 at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.loadPhaseStatements(BuildGlobalContext.java:239)
13:17:21 at org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.buildEffective(BuildGlobalContext.java:198)
13:17:21 at org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction.buildEffective(CrossSourceStatementReactor.java:128)
13:17:21 at org.opendaylight.yangtools.sal.java.api.generator.test.TestUtils.parseYangSources(TestUtils.java:38)
13:17:21 at org.opendaylight.yangtools.sal.java.api.generator.test.TestUtils.parseYangSources(TestUtils.java:49)
13:17:21 at org.opendaylight.yangtools.sal.java.api.generator.test.TestUtils.parseYangSources(TestUtils.java:53)
13:17:21 at org.opendaylight.yangtools.sal.java.api.generator.test.CompilationTest.generateTestSources(CompilationTest.java:666)
13:17:21 at org.opendaylight.yangtools.sal.java.api.generator.test.CompilationTest.testGenerationContextReferenceExtension(CompilationTest.java:444)
13:17:21

 Comments   
Comment by A H [ 21/Oct/16 ]

Could it be related these two patches?

https://git.opendaylight.org/gerrit/#/c/47223/
https://git.opendaylight.org/gerrit/#/c/47200/

Comment by Michael Vorburger [ 23/Oct/16 ]

> Could it be related these two patches?
> https://git.opendaylight.org/gerrit/#/c/47223/
> https://git.opendaylight.org/gerrit/#/c/47200/

No, I'm 99.9% sure that this isn't cause by either of those two... I've just (locally) reverted both, one after the other as well as both together; but the same test failure still occurs. So this must be caused by something else..

Note that on master this CompilationTest.testGenerationContextReferenceExtension fails as well.

I'll now spend a max. 1/2h time boxed to debug the test and try to understand and fix the failure. (If do not comment any further in this issue, I was unsuccessful.)

Comment by Michael Vorburger [ 23/Oct/16 ]

I've just found that this test failure is caused by commit c157a9dd65426473b7cd87de68d6639c9e91f403 which was for YANGTOOLS-692 "Define a namespace to hold model-defined statements" .. reverting everything up to that patch fixes this test. I'll now try to revert only that patch, to see if that alone is sufficient.

NB: It MAY well be that the problem is more in that test than the patch, but Robert should make that determination in the coming days. I'll limit myself to identify which change introduced the test failure here.

Comment by Michael Vorburger [ 23/Oct/16 ]

> revert only that patch, to see if that alone is sufficient

Indeed it is; so I've raised https://git.opendaylight.org/gerrit/#/c/47389/, which will fix this CompilationTest failure. Again it's possible that this is more of a problem in that test than a real issue - I'm unable to tell (Robert will).

YANGTOOLS-692 seems to be about "just" a memory optimization; so my recommendation, given that this is a Blocker for Boron SR1 release, would be that someone merge my c/47389 revert - and close this issue as done. I've re-opened YANGTOOLS-692 so that it can be re-introduced after rework, or just fix up CompilationTest (and it will have to be done on both stable/boron and master there).

Comment by Robert Varga [ 23/Oct/16 ]

master: https://git.opendaylight.org/gerrit/47399
boron: https://git.opendaylight.org/gerrit/47403

The "just" optimization has a side effect of actually fixing a bug, which allowed this invalid YANG to pass validation.

Generated at Wed Feb 07 20:09:01 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.