|
Attachment ietf-routing-types@2017-02-27.yang has been added with description: yang file
|
|
This issue is related to binding generator and binding codecs, which are parts of mdsal project, therefore I move this bug to mdsal..
|
|
is this master and/or stable/carbon?
|
|
I use 0.11.0-SNAPSHOT
<parent>
<groupId>org.opendaylight.mdsal</groupId>
<artifactId>binding-parent</artifactId>
<version>0.11.0-SNAPSHOT</version>
<relativePath/>
</parent>
|
|
I have similar issue with Carbon-SR2. I noticed that
org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.routing.types.rev170227.MplsLabel
does not have getMplsLabelSpecialPurpose getter,
but mpls-label defines it:
typedef mpls-label {
type union
{
type mpls-label-special-purpose;
type mpls-label-general-use;
}
This causes similar failure when we try to configure labels in Honeycoimb via restconf.
|
|
The problem is located in TypeProviderImpl.resolveExtendedSubtypeAsUnion(), where we ignore the union type as it is derived from an IdentityRef and there is no case statement to assign it.
|
|
Actually, for some reason we do not generate a type for 'typedef mpls-label-special-purpose', which means the union cannot find the type and fails to add the union member.
|
|
Oxygen: https://git.opendaylight.org/gerrit/67757
This also affects binding-v2, but that needs to be addressed separately.
|
|
LeafrefTypeDefinition was fixed previously in MDSAL-253, but that did not fix IdentityrefTypeDefinition nor binding2.
|
|
Root Cause Analysis:
This issue comes from the decision to not change generated identityref leaf method signature, which means we cannot provide typedef-mandated encapsulation of the identity reference. Hence no encapsulation is done for both identityref and leafref nodes.
While MDSAL-253 took care of the leafref special case for unions, identityref typedefs were not handled and dropped silently.
The fix makes unions aware of identityref and wires them to the leafref case, which produces expected results.
|
|
The patch actually does not fix anything. I can now see the problem, codec expects:
Caused by: java.lang.NoSuchMethodException: org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.routing.types.rev170227.MplsLabel.getMplsLabelSpecialPurpose()
at java.lang.Class.getMethod(Class.java:1778)
while codegen generates:
public java.lang.Class<? extends org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.routing.types.rev170227.MplsLabelSpecialPurposeValue> getClassMplsLabelValue()
{
return _classMplsLabelValue;
}
e.g. codegen does not take the typedef into account at all, while it should for naming purposes – the method name is derived from the identity name, not the type name of the identityref. That actually should be simpler to fix (I hope).
|
|
Updated patch generates the property correctly.
|
|
Property generation works indeed, but now I get some run time issues during deserialization,
that look similar to YANGTOOLS-742.
Stack trace:
Caused by: java.lang.IllegalArgumentException: Failed to construct instance of class org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.routing.types.rev170227.MplsLabel for input (urn:ietf:params:xml:ns:yang:ietf-mpls-static?revision=2017-03-10)111
at org.opendaylight.yangtools.binding.data.codec.impl.UnionTypeCodec.deserialize(UnionTypeCodec.java:114) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.LeafNodeCodecContext.deserializeObject(LeafNodeCodecContext.java:199) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.DataObjectCodecContext.getBindingChildValue(DataObjectCodecContext.java:324) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.getBindingData(LazyDataObject.java:148) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.bindingToString(LazyDataObject.java:205) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.invoke(LazyDataObject.java:65) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at com.sun.proxy.$Proxy115.toString(Unknown Source) ~[na:na]
at java.lang.String.valueOf(String.java:2994) ~[na:1.8.0_151]
at java.lang.StringBuilder.append(StringBuilder.java:131) ~[na:1.8.0_151]
at com.google.common.base.MoreObjects$ToStringHelper.toString(MoreObjects.java:350) ~[guava-22.0.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.bindingToString(LazyDataObject.java:210) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.invoke(LazyDataObject.java:65) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at com.sun.proxy.$Proxy112.toString(Unknown Source) ~[na:na]
at java.lang.String.valueOf(String.java:2994) ~[na:1.8.0_151]
at java.lang.StringBuilder.append(StringBuilder.java:131) ~[na:1.8.0_151]
at com.google.common.base.MoreObjects$ToStringHelper.toString(MoreObjects.java:350) ~[guava-22.0.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.bindingToString(LazyDataObject.java:210) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.invoke(LazyDataObject.java:65) ~[mdsal-binding-dom-codec-0.11.2-SNAPSHOT.jar:na]
at com.sun.proxy.$Proxy111.toString(Unknown Source) ~[na:na]
at java.util.Formatter$FormatSpecifier.printString(Formatter.java:2886) ~[na:1.8.0_151]
at java.util.Formatter$FormatSpecifier.print(Formatter.java:2763) ~[na:1.8.0_151]
at java.util.Formatter.format(Formatter.java:2520) ~[na:1.8.0_151]
at java.util.Formatter.format(Formatter.java:2455) ~[na:1.8.0_151]
at java.lang.String.format(String.java:2940) ~[na:1.8.0_151]
at io.fd.honeycomb.translate.write.WriteFailedException$CreateFailedException.getMsg(WriteFailedException.java:114) ~[translate-api-1.18.01.1-SNAPSHOT.jar:na]
|
|
This exception is thrown when no member codec accepts the incoming value. Enable debug on UnionValueOptionContext to see what went down. Judging from the value it should have been intercepted by mpls-label-general-use...
Please file a separate issue.
|
|
DOne: MDSAL-307
|
Generated at Wed Feb 07 20:09:18 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.
ietf-routing-types@2017-02-27.yang