[MDSAL-271] About Namespace Created: 23/Jun/17 Updated: 16/Mar/19 Resolved: 16/Mar/19 |
|
| Status: | Resolved |
| Project: | mdsal |
| Component/s: | Binding V2 codegen, Binding V2 runtime |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Jie Han | Assignee: | Jie Han |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Attachments: |
|
||||||||
| Issue Links: |
|
||||||||
| External issue ID: | 8731 | ||||||||
| Description |
|
As in binding2-spec , providing "Data" & "Grouping" suffixs to resolve confliction of type name in the same package, In my opinion, there should also provide the namesapce 'data' and 'grp' at sub levels, just shown right side of '->' below, module namespace-test-foo2 { grouping a { // data.a.a.AGrouping -> data.a.data.a.grp.A }} grouping a { // data.a.AGrouping -> data.a.grp.A grouping a { // data.a.a.a.AGrouping -> data.a.grp.a.data.a.grp.A }} grouping a { // data.a.a.AGrouping -> data.a.grp.a.grp.A grouping a { // data.a.a.a.AGrouping -> data.a.grp.a.grp.a.grp.A } } grouping a { // grp.AGrouping -> grp.A grouping a { // grp.a.a.AGrouping -> grp.a.data.a.grp.A }} grouping a { // grp.a.AGrouping -> grp.a.grp.A grouping a { // grp.a.a.AGrouping -> grp.a.grp.a.grp.A } } |
| Comments |
| Comment by Martin Ciglan [ 03/Jul/17 ] |
|
Hi Jie is this fully working in patches you have pushed? Can you provide links to gerrit? Thanks. |
| Comment by Jie Han [ 03/Jul/17 ] |
|
(In reply to Martin Ciglan from comment #1) Nope, I'am not sure if this design would be agreed, so I did not implement it (if need, I would push another patch for it),
But after these, there still exist clashes for the same method in two groupings which one of them uses the other. |
| Comment by Jie Han [ 03/Jul/17 ] |
|
Attachment uses.png has been added with description: original design |
| Comment by Jie Han [ 03/Jul/17 ] |
|
Attachment uses-001.png has been added with description: improved design 1 |
| Comment by Jie Han [ 03/Jul/17 ] |
|
Attachment uses-002.png has been added with description: improved design 2 |
| Comment by Jie Han [ 03/Jul/17 ] |
|
(In reply to Jie Han from comment #2) Hi, Martin, I did a mistake about clash, it's not necessary to add suffix to getter, I would fix this back later together with improving implements from uses according to the specification document. |
| Comment by Martin Ciglan [ 14/Jul/17 ] |
|
is this still valid bug with all patches up to today merged? |
| Comment by Jie Han [ 17/Jul/17 ] |
|
(In reply to Martin Ciglan from comment #7) Yes, it's not resolved yet. |
| Comment by Jie Han [ 13/Sep/18 ] |
| Comment by Robert Varga [ 16/Mar/19 ] |
|
Binding V2 is being removed in 4.0.0. |