[MDSAL-303] Do not allow null RPC input in invocation paths Created: 26/Jan/18 Updated: 03/Jun/20 Resolved: 20/Apr/20 |
|
| Status: | Resolved |
| Project: | mdsal |
| Component/s: | DOM API, DOM runtime |
| Affects Version/s: | None |
| Fix Version/s: | 6.0.0 |
| Type: | Improvement | Priority: | Medium |
| Reporter: | Robert Varga | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Issue Links: |
|
||||||||||||||||
| Description |
|
RFC6020 and RFC7950 make it clear the RPC input statement is always present. DOM perspective this means that RPCs always have an input NormalizedNode. DOMRpcService.invokeRpc() should therefore either not allow nulls in its API contract, or have @implSpec of turning nulls into an empty ContainerNode, on which presence of mandatory leaves is enforced (triggering IllegalArgumentException in such a case). This change is required to correctly account for RPC input such that default values can be inferred. |