[MDSAL-372] Migrate generated annotations to JDT Created: 08/Oct/18 Updated: 12/Feb/19 Resolved: 12/Feb/19 |
|
| Status: | Resolved |
| Project: | mdsal |
| Component/s: | Binding codegen |
| Affects Version/s: | None |
| Fix Version/s: | 3.0.7 |
| Type: | Improvement | Priority: | Low |
| Reporter: | Robert Varga | Assignee: | Unassigned |
| Resolution: | Done | Votes: | 0 |
| Labels: | java11 | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
javax.annotation.Nullable has wrong retention, which leads to javax.annotation being generated as an OSGi import. Teach codegen about type use annotations, so we can correctly generate JDT annotations and switch to using them. |
| Comments |
| Comment by Robert Varga [ 08/Oct/18 ] |
|
I think we can get by moving annotations from the type model (mdsal-binding-generator-api) to the generator itself. This will save us some memory overhead at runtime and simplify things for the generator. As a side-note, we will need to ditch CheckReturnValue, too. |
| Comment by Robert Varga [ 09/Oct/18 ] |
|
This is not necessary after all - odlparent-4.0.3 will fix the issue for us. |
| Comment by Robert Varga [ 15/Oct/18 ] |
|
At some point we need to migrate away from JSR305 anyway, so let's keep this issue open. |