[MDSAL-601] Improve InstanceIdentifier annotations Created: 18/Oct/20 Updated: 22/Oct/20 Resolved: 19/Oct/20 |
|
| Status: | Resolved |
| Project: | mdsal |
| Component/s: | Binding API |
| Affects Version/s: | None |
| Fix Version/s: | 5.0.15, 7.0.1, 6.0.7 |
| Type: | Improvement | Priority: | High |
| Reporter: | Robert Varga | Assignee: | Robert Varga |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Description |
|
We are using Eclipse annotations and Eclipse ends up being very noisy if you enable nullness analysis. One part of it revolves around our use of .class references in APIs – while the APIs do not specify nullness, Eclipse treats the class reference in InstanceIdentifier.create(Foo.class) as Class<@NonNull Foo>, and, very unhelpfully, generates a warning when it meets InstanceIdentifier's lack of annotations. This is perhaps an issue with Eclipse, but at the end of the day we need to support everyone. Improve the situation by taking into account Eclipse's short falls and annotate InstanceIdentifier to keep it happy. |