[MDSAL-679] ActionProviderService is not registering action into DOMRpcRouter Created: 26/Jul/21  Updated: 11/Aug/21  Resolved: 11/Aug/21

Status: Resolved
Project: mdsal
Component/s: None
Affects Version/s: 6.0.10, 8.0.1, 7.0.8
Fix Version/s: 6.0.11, 7.0.9, 8.0.2

Type: Bug Priority: Medium
Reporter: Peter Suna Assignee: Ivan Hrasko
Resolution: Done Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to MDSAL-681 DOMActionProviderService does not sup... Resolved

 Description   

To register an action ActionProviderService method registerImplementation(...) is called. When using ActionProviderServiceAdapter implementation this method will provide an empty set as action supported operation identifiers (instances).

This prevents us from successfully registering action into DOMRpcRoutingTable.

ActionProviderServiceAdapter#registerImplementation():

https://github.com/opendaylight/mdsal/blob/12879467c0adaecc410b685681af4c2c112b4bca/binding/mdsal-binding-dom-adapter/src/main/java/org/opendaylight/mdsal/binding/dom/adapter/ActionProviderServiceAdapter.java#L72

DOMActionProviderService#registerActionImplementation:

https://github.com/opendaylight/mdsal/blob/12879467c0adaecc410b685681af4c2c112b4bca/dom/mdsal-dom-api/src/main/java/org/opendaylight/mdsal/dom/api/DOMActionProviderService.java#L33

final DOMRpcRoutingTable newTable = (DOMRpcRoutingTable) oldTable.add(implementation, rpcs):

https://github.com/opendaylight/mdsal/blob/12879467c0adaecc410b685681af4c2c112b4bca/dom/mdsal-dom-broker/src/main/java/org/opendaylight/mdsal/dom/broker/AbstractDOMRoutingTable.java#L68

 Comments   
Comment by Robert Varga [ 11/Aug/21 ]

The primary problem has been fixed, i.e. the adapter now correctly forwards registered instances.

Note that the wildcard registrations are still a no-op, but that requires more substantial changes at the DOM layer – and that will be taken care of by MDSAL-681.

 

Generated at Wed Feb 07 20:10:31 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.