[NETCONF-1116] Do not use RpcService in NETCONF components Created: 03/Aug/23  Updated: 25/Sep/23  Resolved: 25/Sep/23

Status: Resolved
Project: netconf
Component/s: None
Affects Version/s: None
Fix Version/s: 7.0.0

Type: Task Priority: Medium
Reporter: Robert Varga Assignee: Oleksandr Zharov
Resolution: Done Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Blocks
blocks MDSAL-772 Remove RpcService Resolved

 Description   

A quick grep is showing these users of deprecated API:

./netconf/apps/netconf-topology-impl/src/main/java/org/opendaylight/netconf/topology/impl/NetconfTopologyImpl.java:        rpcReg = rpcProviderService.registerRpcImplementation(NetconfNodeTopologyService.class,
./netconf/apps/netconf-topology-singleton/src/main/java/org/opendaylight/netconf/topology/singleton/impl/NetconfTopologyManager.java:        rpcReg = rpcProviderService.registerRpcImplementation(NetconfNodeTopologyService.class,
./netconf/netconf/tools/netconf-test-perf/src/main/java/org/opendaylight/test/endtoend/EndtoendTestService.java:        registration = rpcProviderService.registerRpcImplementation(NcmountService.class,
./netconf/plugins/netconf-client-mdsal/src/main/java/org/opendaylight/netconf/client/mdsal/impl/NetconfSalKeystoreService.java:        reg = rpcProvider.registerRpcImplementation(NetconfKeystoreService.class, this);
./netconf/plugins/netconf-client-mdsal/src/test/java/org/opendaylight/netconf/client/mdsal/impl/NetconfSalKeystoreServiceTest.java:        doReturn(rpcReg).when(rpcProvider).registerRpcImplementation(eq(NetconfKeystoreService.class), any());

Convert them to new-style yang.binding.Rpc-based implementations.



 Comments   
Comment by Ivan Hrasko [ 25/Sep/23 ]

We still have one occurence of RPC service usage in MountPointEndToEndTest class.

Comment by Oleksandr Zharov [ 25/Sep/23 ]

If you are talking about RpcProviderService - then it is fine - it should be like that.

Comment by Ivan Hrasko [ 25/Sep/23 ]

ACK

Generated at Wed Feb 07 20:16:43 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.