[NETCONF-1192] Duplicate 'ignore-missing-schema-sources' in the NETCONF node Created: 28/Oct/23  Updated: 08/Dec/23  Resolved: 08/Dec/23

Status: Resolved
Project: netconf
Component/s: netconf-topology
Affects Version/s: 6.0.4, 5.0.9
Fix Version/s: 7.0.0, 5.0.10, 6.0.6

Type: Bug Priority: Medium
Reporter: Sangwook Ha Assignee: Peter Suna
Resolution: Done Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to NETCONF-670 ignore-missing-schema-sources not all... Resolved
relates to NETCONF-925 Rework optional reconnect logic Confirmed

 Description   

Currently there are two ignore-missing-schema-sources in the topology node for topology-netconf augmented from two modules:

Among those two, only the first one is used at all although there is no real effect other than generating a log message when allowed is set to true since the implementation was removed for v5.0.0 and hasn't been implemented yet (NETCONF-925).

Another issue is that when the ignore-missing-schema-sources parameters are configured using the netconf-node-topology:create-device RPC, the parameters are saved under the netconf-node-topology:ignore-missing-schema-sources node, hence it does not have any effect and won't have any effect even if the feature is implemented.



 Comments   
Comment by Peter Suna [ 29/Nov/23 ]

The task NETCONF-670 addressed the issue of a failed create-device RPC request, which resulted from a missing ignore-missing-schema-sources container. The resolution involved adding this container to the netconf-node-fields grouping, a field utilized in both the necessary RPC request and the augmentation.

Notably, this augmentation is the duplicity with a field created in the netconf-node-optional YANG model. This mistake became more apparent during subsequent model refactoring efforts.

Comment by Peter Suna [ 07/Dec/23 ]

Example for create-device RPC request:

curl --location 'http://192.168.56.100:8181/rests/operations/netconf-node-topology:create-device' \
--header 'Authorization: Basic YWRtaW46YWRtaW4=' \
--header 'Content-Type: application/json' \
--data '{
    "input": {
        "login-password": {
            "password": "admin",
            "username": "admin"
        },
        "ignore-missing-schema-sources": {
            "reconnect-time": 5000,
            "allowed": true
        },
        "netconf-node-topology:node-id": "new-node",
        "actor-response-wait-time": 900,
        "concurrent-rpc-limit": 0,
        "host": "127.0.0.1",
        "sleep-factor": 1,
        "port": 17830,
        "tcp-only": false,
        "connection-timeout-millis": 20000,
        "max-connection-attempts": 0,
        "keepalive-delay": 300,
        "between-attempts-timeout-millis": 2000,
        "schemaless": false,
        "default-request-timeout-millis": 600000
    }
Generated at Wed Feb 07 20:16:53 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.