[NETCONF-1220] Hard-coded /rests endpoint in stream locations Created: 08/Jan/24  Updated: 31/Jan/24

Status: Confirmed
Project: netconf
Component/s: restconf-nb
Affects Version/s: 5.0.0, 6.0.0
Fix Version/s: 5.0.10, 6.0.7

Type: Bug Priority: Medium
Reporter: Ivan Hrasko Assignee: Ivan Hrasko
Resolution: Unresolved Votes: 0
Labels: pt
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified


 Description   

We creating streams name using hard-coded constant RestconfConstants.BASE_URI_PATTERN.

This issue is on 6.0.x and 5.0.x branch in SubscribeToStreamUtil class. We get uriInfo as a parameter here from which we should set the base uri. But this is not the case, and we are replacing the restconf uri with RestconfConstants.BASE_URI_PATTERN which is constantly set to "rests".

This causes issues like:
https://github.com/PANTHEONtech/lighty/issues/1682

It means client configuration is ignored and "rests" is always used. Fix that.



 Comments   
Comment by Robert Varga [ 23/Jan/24 ]

The patch is missing bits for:

  • WebSockets
  • ListenersBroker.createStreamNameFromUri()
Comment by Ivan Hrasko [ 23/Jan/24 ]

We were hoping that it will be addressed in NETCONF-1218. This task is really for this single case only.

Generated at Wed Feb 07 20:16:57 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.