[NETCONF-129] ODL tolerates bash-style comments in JSON data Created: 19/Jan/16  Updated: 13/Aug/19

Status: Confirmed
Project: netconf
Component/s: restconf-nb
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Vratko Polak Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 5015

 Description   

This was seen both on Lithium and Beryllium.

During review of integration/test change, I have seen a contribution which had left bash-style comments in their JSON data, but Sandbox job was 100% passing. To remove possibility of Robot libraries doing some processing, I have created test Change 32890 [0]. From patch set 1-5, only #2 fails.

So it looks like (the JSON Java library used by) ODL removes such comments, which is not strict JSON behavior.
This is not necessarily a bad thing, but ODL wiki [1] should mention this functionality.
Or ODL should disable it, perhaps squeezing out some performance improvement.

[0] https://git.opendaylight.org/gerrit/32890
[1] https://wiki.opendaylight.org/view/OpenDaylight_Controller:MD-SAL:Restconf#Supported_data_formats


Generated at Wed Feb 07 20:14:14 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.