[NETCONF-149] Beryllium RC3: some CSIT jobs aborting. IllegalStateException when loading odl-netconf-client Created: 13/Feb/16 Updated: 15/Mar/19 Resolved: 17/Feb/16 |
|
| Status: | Verified |
| Project: | netconf |
| Component/s: | netconf |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Jamo Luhrsen | Assignee: | Tomas Cere |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Attachments: |
|
| External issue ID: | 5346 |
| Description |
|
https://jenkins.opendaylight.org/releng/job/bgpcep-csit-1node-userfeatures-only-beryllium/1085/ trace from log (full log of one example attached) 2016-02-13 13:44:54,516 | ERROR | config-pusher | ConfigPusherImpl | 108 - org.opendaylight.controller.config-persister-impl - 0.4.0.Beryllium | Failed to apply configuration snapshot: 01-netconf.xml(odl-netconf-client,odl-netconf-client) ] to attribute worker-thread-group |
| Comments |
| Comment by Jamo Luhrsen [ 13/Feb/16 ] |
|
sorry, I do not have a full karaf.log. The console output from one of jobs is attached which gives the first and last 500K bytes. Note, there are a ton of AuthenticationExceptions, but those are expected as it's our polling on restconf by our bringup script |
| Comment by Jamo Luhrsen [ 13/Feb/16 ] |
|
Attachment 5346.karaf.log.gz has been added with description: first and last 500K bytes of karaf.log |
| Comment by Vratko Polak [ 15/Feb/16 ] |
|
These failures do not happen with Beryllium snapshot builds, but they do not happen when testing RC3 on Sandbox [0] either. Common denominator is netconf connector. The jobs either install odl-netconf-connector-all (in job definition), or they install odl-netconf-connector (via odl-usc-channel). The error message mentions odl-netconf-client feature, while global-worker-group is defined in 00-netty.xml config file of odl-config-netty feature (which is not listed as dependency of odl-netconf-client). Probably, the 00-netty.xml is pulled in by some other feature being installed, and it depends on system performance whether ODL detects the transient inconsistency or not. Change 34675 [1] contributed to address the dependency issue, but there may be more hidden issues of this type, see comments of [0] https://jenkins.opendaylight.org/sandbox/job/netconf-csit-1node-userfeatures-only-beryllium/1 |
| Comment by Colin Dixon [ 15/Feb/16 ] |
|
Thanks Vratko! Is this related? > 2016-02-13 13:44:49,924 | INFO | Event Dispatcher | YangTextSchemaContextResolver | 69 - org.opendaylight.yangtools.yang-parser-impl - 0.8.0.Beryllium | Provided module name /META-INF/yang/threadpool.yang@0000-00-00.yang does not match actual text threadpool@2013-04-09.yang, corrected |
| Comment by Vratko Polak [ 15/Feb/16 ] |
|
> https://git.opendaylight.org/gerrit/34675 https://jenkins.opendaylight.org/releng/view/netconf/job/netconf-csit-1node-userfeatures-only-beryllium/206 But I do not see an easy way to verify its supposed effect on autorelease builds, without actually making new autorelease build with the Change merged. |
| Comment by Vratko Polak [ 15/Feb/16 ] |
|
> Is this related? No, that is a warning from new Yangtools parser, after the automatic source name conversion everything works. |
| Comment by Jamo Luhrsen [ 15/Feb/16 ] |
|
This means we are re-spinning the release right? there are other "ready-to-submit" patches out there as well. |
| Comment by Jamo Luhrsen [ 15/Feb/16 ] |
|
This means we are re-spinning the release right? there are other "ready-to-submit" patches out there as well. |
| Comment by Vratko Polak [ 15/Feb/16 ] |
|
> we are re-spinning the release right? +1 |
| Comment by A H [ 15/Feb/16 ] |
|
Severity: Could you elaborate on the severity of this bug? Is this a BLOCKER such that we cannot release Beryllium without it? Is there a workaround such that we can write a release note and fix in Beryllium SR1? |
| Comment by Jamo Luhrsen [ 15/Feb/16 ] |
|
(In reply to A H from comment #10) I don't know of any workaround, but I didn't really look. IMO this is a > Testing: Could you also elaborate on the testing or this patch? How There are the four system test jobs (initial comment) that will give us > Impact: Does this fix impact any dependent projects? not sure. Hopefully Vratko can add more info here. |
| Comment by A H [ 15/Feb/16 ] |
|
(In reply to Jamo Luhrsen from comment #11) I would also agree that the four CSIT that failed would cover the testing aspects of this patch. > > Impact: Does this fix impact any dependent projects? This fix would impact projects whose CSIT jobs failed originally. We will know more once we rerun these jobs after merging the fix. |
| Comment by Vratko Polak [ 15/Feb/16 ] |
|
> Could you elaborate on the severity of this bug? When user installs a feature related to netconf-connector, ODL may break so that even basic Restconf does not work. This is a blocker unless a workaround is applied. > How extensively has this patch been tested? This Bug is not reproducible on Sandbox or on Snapshot builds, probably because a timing issue. The Bug was reproduced on Releng with original autorelease build. > Is there a workaround such that we can write a release note and fix in Beryllium SR1? If user installs odl-config-netty feature prior anything related to netconf-connector, ODL should work. > Is it covered by any unit tests or system tests? No specific system tests, apart the 4 csit jobs that were reported. > Does this fix impact any dependent projects? No, projects were already expecting netconf-connector to install all its dependencies. |
| Comment by Vratko Polak [ 16/Feb/16 ] |
|
The bgpcep job triggered with autorelease URL on RelEng Jenkins works again [0]. |
| Comment by A H [ 17/Feb/16 ] |
|
Have we been able to verify the fix for this bug? |
| Comment by Jamo Luhrsen [ 17/Feb/16 ] |
|
(In reply to A H from comment #15) using the CSIT jobs with RC3 we can mark this verified. |