[NETCONF-248] Incorrect handling of configuration failures in SAL netconf connector Created: 05/Aug/16  Updated: 15/Mar/19  Resolved: 21/Sep/16

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Tomas Janciga Assignee: Jakub Morvay
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

Attachments: Text File netconf_sal_connector_karaf.log    
External issue ID: 6343

 Description   

Version: 1.1.0-SNAPSHOT (Boron) (master branch)

SAL netconf connector handles invalid configuration just by logging warning message what casues that RESTCONF response indicates result code 200 OK.

Possible solution:
https://git.opendaylight.org/gerrit/gitweb?p=netconf.git;a=blob;f=netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/tx/WriteCandidateTx.java;h=4001c3186b385d16b376421256c9ac66c3dba224;hb=refs/heads/master#l192

In the method onSuccess() there's a check isSuccess(). If the isSuccess returns false, then the warning message is logged. But there should be used the same handling as in the method onFailure().

See attached logs for more details.

 Comments   
Comment by Tomas Janciga [ 05/Aug/16 ]

Attachment netconf_sal_connector_karaf.log has been added with description: Karaf logs showing the configuration sent, it's processing and the warning message logged instead of the appropriate handling.

Comment by Jakub Morvay [ 09/Aug/16 ]

Alexis,

If you are working on this bug, I assume it is real bug, so can you also set status to CONFIRMED?

Comment by Alexis de Talhouët [ 09/Aug/16 ]

Done, thanks.

Comment by Alexis de Talhouët [ 09/Aug/16 ]

https://git.opendaylight.org/gerrit/#/c/43229/

Comment by Rudolf Brisuda [ 25/Aug/16 ]

The actual solution rely on blocking get. I fixed it in: https://git.opendaylight.org/gerrit/#/c/44646/
where exceptions are raised in submit method.

Comment by Rudolf Brisuda [ 25/Aug/16 ]

I abandoned posted url and I made only new patch in https://git.opendaylight.org/gerrit/#/c/43229/

Comment by Jakub Morvay [ 05/Sep/16 ]

Needs to be merged also to Boron

Comment by Jakub Morvay [ 05/Sep/16 ]

Here's patch for stable/boron:

https://git.opendaylight.org/gerrit/#/c/45054/

Generated at Wed Feb 07 20:14:32 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.