[NETCONF-280] need to lock running as well as candidate config in mounted device Created: 19/Sep/16 Updated: 15/Mar/19 Resolved: 14/Oct/16 |
|
| Status: | Resolved |
| Project: | netconf |
| Component/s: | netconf |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Giles Heron | Assignee: | Jakub Morvay |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 6750 |
| Description |
|
when modifying the configuration of a mounted device in response to a RESTCONF PUT or POST request ODL locks the candidate configuration, however it doesn't lock the running configuration. this risks a race condition where the running configuration is edited by another user (e.g. from the CLI) before ODL commits the configuration changes. is it possible to apply a lock to the running configuration as well as the candidate configuration? |
| Comments |
| Comment by Jakub Morvay [ 20/Sep/16 ] |
|
Hi Giles, I have quickly checked the implementation and ODL should lock both candidate and running configurations. Does your device advertise :writable-running capability? |
| Comment by Giles Heron [ 20/Sep/16 ] |
|
no - the device doesn't advertise :writeable-running. but we'd still like running to be locked to prevent other users changing it. |
| Comment by Jakub Morvay [ 20/Sep/16 ] |
|
But is there a way how you can change it then? Anyway I think you can issue a lock through RESTCONF, then edit configuration and finally unlock the device. |
| Comment by Giles Heron [ 20/Sep/16 ] |
|
(In reply to Jakub Morvay from comment #3) you can change the config from the CLI if running-config isn't locked. > Anyway I think you can issue a lock through RESTCONF, then edit The device doesn't expose "ietf-netconf" so there's no way to use RESTCONF to issue a lock command. Even if it did I'd say that's a bit of a kludge... |
| Comment by Jakub Morvay [ 20/Sep/16 ] |
|
Ok then, we can lock also running configuration for devices that advertise just :candidate capability and no :writable-running capability |
| Comment by Giles Heron [ 20/Sep/16 ] |
|
thanks! |
| Comment by Giles Heron [ 20/Sep/16 ] |
|
ah - looks like we don't need this one after all. The box in question implicitly locks running config if you lock candidate... |
| Comment by Jakub Morvay [ 14/Oct/16 ] |
|
I'm closing this bug as locking candidate configuration implicitly could break some devices out there. After |