[NETCONF-315] Add print in debug level when handle and send Netconf messages Created: 14/Nov/16  Updated: 15/Mar/19  Resolved: 24/Apr/17

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: wang chao Assignee: Unassigned
Resolution: Cannot Reproduce Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 7173

 Description   

when locating a netconf problem, the detail of netconf message usually should be printed



 Comments   
Comment by Alexis de Talhouët [ 18/Nov/16 ]

Hello Wang,

The messages seem to be already logged: see https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/listener/NetconfDeviceCommunicator.java#L291

Comment by wang chao [ 21/Nov/16 ]

(In reply to Alexis de Talhouët from comment #1)
> Hello Wang,
>
> The messages seem to be already logged: see
> https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-
> connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/
> listener/NetconfDeviceCommunicator.java#L291

I have seen this print, but it only prints the netconf message when rpc is error. In my print, I also want to see the netconf message in the correct situation.

Comment by Alexis de Talhouët [ 21/Nov/16 ]

Wang,

In the case the message is correct, the log that I linked above will be display: https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/listener/NetconfDeviceCommunicator.java#L291

If the message is incorrect, it will be logged here: https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/listener/NetconfDeviceCommunicator.java#L280-L282

Both case are covered, I just tried them.

Comment by wang chao [ 22/Nov/16 ]

(In reply to Alexis de Talhouët from comment #3)
> Wang,
>
> In the case the message is correct, the log that I linked above will be
> display:
> https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-
> connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/
> listener/NetconfDeviceCommunicator.java#L291
>
> If the message is incorrect, it will be logged here:
> https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-
> connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/
> listener/NetconfDeviceCommunicator.java#L280-L282
>
> Both case are covered, I just tried them.

The message in NetconfDeviceCommunicator.java and AbstractNetconfSession.java should be different. Besides, the log level is trace in NetconfDeviceCommunicator, in daily job, you seldomly set log level to trace, because it will print too much message.

Comment by Tomas Cere [ 24/Apr/17 ]

Messages are already logged in debug, trace logs only include additional information.

Generated at Wed Feb 07 20:14:42 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.