[NETCONF-334] Some netconf notifications do not call the listener callback function Created: 09/Jan/17  Updated: 15/Mar/19  Resolved: 17/Jan/17

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Rong Xu Assignee: Rong Xu
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All


External issue ID: 7491

 Description   

When a device sends a notification message to the ODL controller, some listeners are called, while others do not.

We read the code that NETCONF did not handle the exception during the notification execution. When an exception is thrown by the processing of a notification, the listener behind it cannot be called.



 Comments   
Comment by Rong Xu [ 09/Jan/17 ]

In NetconfDeviceNotificationService:publishNotification, netconf call each notification listener without exception handling.

public synchronized void publishNotification(final DOMNotification notification) {
for (final DOMNotificationListener domNotificationListener : listeners.get(notification.getType()))

{ domNotificationListener.onNotification(notification); }

}

We can catch exceptions thrown by onNotification.

Comment by Rong Xu [ 09/Jan/17 ]

https://git.opendaylight.org/gerrit/#/c/49847/

Generated at Wed Feb 07 20:14:44 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.