[NETCONF-348] "Please try again" should not result in http code 500 Created: 06/Feb/17 Updated: 15/Mar/19 Resolved: 09/Mar/17 |
|
| Status: | Resolved |
| Project: | netconf |
| Component/s: | netconf |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Vratko Polak | Assignee: | Matúš Kubica |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 7741 |
| Description |
|
Recent (February 2nd) result of Netconf cluster job had a failed test case [0] but the karaf.log [1] message suggests client should retry later. The proper status code for this situation is 503. Netconf code should communicate that to the Restconf code. Segment from karaf.log suggests that perhaps there is an underlying issue of new Master not being elected, but currently it is not clear whether the Master would get elected later: 2017-02-02 13:16:21,748 | WARN | ult-dispatcher-3 | ReliableDeliverySupervisor | 201 - com.typesafe.akka.slf4j - 2.4.16 | Association with remote system [akka.tcp://opendaylight-cluster-data@10.29.12.204:2550] has failed, address is now gated for [5000] ms. Reason: [Association failed with [akka.tcp://opendaylight-cluster-data@10.29.12.204:2550]] Caused by: [Connection refused: /10.29.12.204:2550] at org.opendaylight.netconf.topology.singleton.impl.tx.NetconfProxyDOMTransaction$1.onComplete(NetconfProxyDOMTransaction.java:70)[320:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT] at akka.dispatch.OnComplete.internal(Future.scala:258)[200:com.typesafe.akka.actor:2.4.16] at akka.dispatch.OnComplete.internal(Future.scala:256)[200:com.typesafe.akka.actor:2.4.16] at akka.dispatch.japi$CallbackBridge.apply(Future.scala:186)[200:com.typesafe.akka.actor:2.4.16] at akka.dispatch.japi$CallbackBridge.apply(Future.scala:183)[200:com.typesafe.akka.actor:2.4.16] at scala.concurrent.impl.CallbackRunnable.run(Promise.scala:32)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8] at akka.dispatch.BatchingExecutor$AbstractBatch.processBatch(BatchingExecutor.scala:55)[200:com.typesafe.akka.actor:2.4.16] at akka.dispatch.BatchingExecutor$BlockableBatch$$anonfun$run$1.apply$mcV$sp(BatchingExecutor.scala:91)[200:com.typesafe.akka.actor:2.4.16] at akka.dispatch.BatchingExecutor$BlockableBatch$$anonfun$run$1.apply(BatchingExecutor.scala:91)[200:com.typesafe.akka.actor:2.4.16] at akka.dispatch.BatchingExecutor$BlockableBatch$$anonfun$run$1.apply(BatchingExecutor.scala:91)[200:com.typesafe.akka.actor:2.4.16] at scala.concurrent.BlockContext$.withBlockContext(BlockContext.scala:72)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8] at akka.dispatch.BatchingExecutor$BlockableBatch.run(BatchingExecutor.scala:90)[200:com.typesafe.akka.actor:2.4.16] at akka.dispatch.TaskInvocation.run(AbstractDispatcher.scala:39)[200:com.typesafe.akka.actor:2.4.16] at akka.dispatch.ForkJoinExecutorConfigurator$AkkaForkJoinTask.exec(AbstractDispatcher.scala:415)[200:com.typesafe.akka.actor:2.4.16] at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8] at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8] at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8] at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8] 2017-02-02 13:16:23,476 | ERROR | lt-dispatcher-19 | ExecutionList | 84 - com.google.guava - 18.0.0 | RuntimeException while executing runnable com.google.common.util.concurrent.Futures$6@5738a853 with executor INSTANCE org.opendaylight.netconf.sal.restconf.impl.RestconfDocumentedException: errors: [RestconfError [error-type: application, error-tag: operation-failed, error-message: Problem to get data from transaction., error-info: NetconfDocumentedException{message=RemoteDevice{netconf-test-device} :Master is down. Please try again., errorType=APPLICATION, errorTag=OPERATION_FAILED, errorSeverity=WARNING, errorInfo={}} :Master is down. Please try again., errorType=APPLICATION, errorTag=OPERATION_FAILED, errorSeverity=WARNING, errorInfo={}} [0] https://logs.opendaylight.org/releng/jenkins092/netconf-csit-3node-clustering-only-carbon/435/archives/log.html.gz#s1-s6-t12-k2-k1-k3-k7-k1 |
| Comments |
| Comment by Vratko Polak [ 06/Feb/17 ] |
|
The message returned by Restconf, as it contains different keywords to search for: <errors xmlns="urn:ietf:params:xml:ns:yang:ietf-restconf"><error><error-type>application</error-type><error-tag>operation-failed</error-tag><error-message>Problem while PUT operations</error-message></error></errors> |
| Comment by Vratko Polak [ 09/Feb/17 ] |
|
> perhaps there is an underlying issue of new Master not being elected This Bug is not concerned abut this symptom. Master being down is a bad thing, but it is reported as |
| Comment by Vratko Polak [ 09/Feb/17 ] |
|
This bug is about "Please try again" (caused by whatever reason) turning into status 500 instead of 503. |
| Comment by Matúš Kubica [ 28/Feb/17 ] |