[NETCONF-350] NPE when NetconfDeviceSalProvider.close Created: 16/Feb/17  Updated: 15/Mar/19  Resolved: 13/Apr/17

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Claudio David Gasparini Assignee: Matúš Kubica
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 7812

 Description   

NPE observed during bgpcep-csit-3node-periodic-bgpclustering-only-carbon test

org.opendaylight.netconf.sal.connect.netconf.sal.NetconfDeviceSalProvider@366a9057
java.lang.NullPointerException
at org.opendaylight.netconf.sal.connect.netconf.sal.NetconfDeviceSalProvider.close(NetconfDeviceSalProvider.java:115)[343:org.opendaylight.netconf.sal-netconf-connector:1.5.0.SNAPSHOT]
at org.opendaylight.netconf.topology.singleton.impl.MasterSalFacade.closeGracefully(MasterSalFacade.java:170)[346:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT]
at org.opendaylight.netconf.topology.singleton.impl.MasterSalFacade.close(MasterSalFacade.java:122)[346:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT]
at org.opendaylight.netconf.topology.singleton.impl.utils.NetconfConnectorDTO.close(NetconfConnectorDTO.java:45)[346:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT]
at org.opendaylight.netconf.topology.singleton.impl.RemoteDeviceConnectorImpl.stopRemoteDeviceConnection(RemoteDeviceConnectorImpl.java:154)[346:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT]
at org.opendaylight.netconf.topology.singleton.impl.NetconfTopologyContext.closeServiceInstance(NetconfTopologyContext.java:98)[346:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT]
at org.opendaylight.mdsal.singleton.dom.impl.ClusterSingletonServiceRegistrationDelegator.closeServiceInstance(ClusterSingletonServiceRegistrationDelegator.java:52)[182:org.opendaylight.mdsal.singleton-dom-impl:2.2.0.SNAPSHOT]
at org.opendaylight.mdsal.singleton.dom.impl.ClusterSingletonServiceGroupImpl.lostOwnership(ClusterSingletonServiceGroupImpl.java:338)[182:org.opendaylight.mdsal.singleton-dom-impl:2.2.0.SNAPSHOT]
at org.opendaylight.mdsal.singleton.dom.impl.ClusterSingletonServiceGroupImpl.ownershipChanged(ClusterSingletonServiceGroupImpl.java:238)[182:org.opendaylight.mdsal.singleton-dom-impl:2.2.0.SNAPSHOT]
at org.opendaylight.mdsal.singleton.dom.impl.AbstractClusterSingletonServiceProviderImpl.ownershipChanged(AbstractClusterSingletonServiceProviderImpl.java:146)[182:org.opendaylight.mdsal.singleton-dom-impl:2.2.0.SNAPSHOT]
at org.opendaylight.mdsal.singleton.dom.impl.DOMClusterSingletonServiceProviderImpl.ownershipChanged(DOMClusterSingletonServiceProviderImpl.java:23)[182:org.opendaylight.mdsal.singleton-dom-impl:2.2.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnershipListenerActor.onEntityOwnershipChanged(EntityOwnershipListenerActor.java:44)[234:org.opendaylight.controller.sal-distributed-datastore:1.5.0.SNAPSHOT]
at org.opendaylight.controller.cluster.datastore.entityownership.EntityOwnershipListenerActor.handleReceive(EntityOwnershipListenerActor.java:33)[234:org.opendaylight.controller.sal-distributed-datastore:1.5.0.SNAPSHOT]
at org.opendaylight.controller.cluster.common.actor.AbstractUntypedActor.onReceive(AbstractUntypedActor.java:28)[227:org.opendaylight.controller.sal-clustering-commons:1.5.0.SNAPSHOT]
at akka.actor.UntypedActor$$anonfun$receive$1.applyOrElse(UntypedActor.scala:165)[200:com.typesafe.akka.actor:2.4.16]
at akka.actor.Actor$class.aroundReceive(Actor.scala:496)[200:com.typesafe.akka.actor:2.4.16]
at akka.actor.UntypedActor.aroundReceive(UntypedActor.scala:95)[200:com.typesafe.akka.actor:2.4.16]
at akka.actor.ActorCell.receiveMessage(ActorCell.scala:526)[200:com.typesafe.akka.actor:2.4.16]
at akka.actor.ActorCell.invoke(ActorCell.scala:495)[200:com.typesafe.akka.actor:2.4.16]
at akka.dispatch.Mailbox.processMailbox(Mailbox.scala:257)[200:com.typesafe.akka.actor:2.4.16]
at akka.dispatch.Mailbox.run(Mailbox.scala:224)[200:com.typesafe.akka.actor:2.4.16]
at akka.dispatch.Mailbox.exec(Mailbox.scala:234)[200:com.typesafe.akka.actor:2.4.16]
at scala.concurrent.forkjoin.ForkJoinTask.doExec(ForkJoinTask.java:260)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8]
at scala.concurrent.forkjoin.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1339)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8]
at scala.concurrent.forkjoin.ForkJoinPool.runWorker(ForkJoinPool.java:1979)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8]
at scala.concurrent.forkjoin.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:107)[196:org.scala-lang.scala-library:2.11.8.v20160304-115712-1706a37eb8]

 Comments   
Comment by Claudio David Gasparini [ 16/Feb/17 ]

temporal logs
https://logs.opendaylight.org/sandbox/jenkins091/bgpcep-csit-3node-periodic-bgpclustering-only-carbon/5/archives/odl1_karaf.log.gz

Comment by Claudio David Gasparini [ 17/Feb/17 ]

2017-02-17 08:34:32,278 | ERROR | sing-executor-11 | NetconfDevice | 341 - org.opendaylight.netconf.sal-netconf-connector - 1.5.0.SNAPSHOT | RemoteDevice

{test-device}

: Initialization in sal failed, disconnecting from device java.lang.NullPointerException: Closed at com.google.common.base.Preconditions.checkNotNull(Preconditions.java:226)[84:com.google.guava:18.0.0] at org.opendaylight.netconf.sal.connect.netconf.sal.NetconfDeviceSalProvider$MountInstance.onTopologyDeviceConnected(NetconfDeviceSalProvider.java:137)[341:org.opendaylight.netconf.sal-netconf-connector:1.5.0.SNAPSHOT] at org.opendaylight.netconf.topology.singleton.impl.MasterSalFacade.registerMasterMountPoint(MasterSalFacade.java:141)[344:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT] at org.opendaylight.netconf.topology.singleton.impl.MasterSalFacade.onDeviceConnected(MasterSalFacade.java:87)[344:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT] at org.opendaylight.netconf.topology.singleton.impl.MasterSalFacade.onDeviceConnected(MasterSalFacade.java:43)[344:org.opendaylight.netconf.topology-singleton:1.2.0.SNAPSHOT] at org.opendaylight.netconf.sal.connect.netconf.NetconfDevice.handleSalInitializationSuccess(NetconfDevice.java:217)[341:org.opendaylight.netconf.sal-netconf-connector:1.5.0.SNAPSHOT] at org.opendaylight.netconf.sal.connect.netconf.NetconfDevice$SchemaSetup.setUpSchema(NetconfDevice.java:465)[341:org.opendaylight.netconf.sal-netconf-connector:1.5.0.SNAPSHOT] at org.opendaylight.netconf.sal.connect.netconf.NetconfDevice$SchemaSetup.run(NetconfDevice.java:430)[341:org.opendaylight.netconf.sal-netconf-connector:1.5.0.SNAPSHOT] at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)[:1.8.0_121] at java.util.concurrent.FutureTask.run(FutureTask.java:266)[:1.8.0_121] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)[:1.8.0_121] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)[:1.8.0_121] at java.lang.Thread.run(Thread.java:745)[:1.8.0_121]

Comment by Matúš Kubica [ 14/Mar/17 ]

This bug should be fixed by patch:
https://git.opendaylight.org/gerrit/#/c/52346/1

Comment by Matúš Kubica [ 04/Apr/17 ]

Cherry-picked on boron-4

https://git.opendaylight.org/gerrit/#/c/54306/1

Comment by Claudio David Gasparini [ 05/Apr/17 ]

Shouldn't be closed until fixes are merged.

Regards

Comment by Matúš Kubica [ 13/Apr/17 ]

Bug fix was merged
https://git.opendaylight.org/gerrit/#/c/54306/

Generated at Wed Feb 07 20:14:47 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.