keepalive-rcp-reply-error.log
[NETCONF-440] rpc-error in keepalive rpc-reply shouldn't bounce the session Created: 10/Jul/17 Updated: 15/Mar/19 Resolved: 17/Jul/17 |
|
| Status: | Resolved |
| Project: | netconf |
| Component/s: | netconf |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Alexis de Talhouët | Assignee: | Alexis de Talhouët |
| Resolution: | Done | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| Attachments: |
keepalive-rcp-reply-error.log
|
| External issue ID: | 8832 |
| Description |
|
If the keepalive rpc-reply has errors, it means the other end of the session is still available, hence the session shouldn't be bounced. Current implementation for keepalive only checks for results but not for errors: https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/KeepaliveSalFacade.java#L207 Implementation for other rpcs is ok, and doesn't even check the content of the result, assuming that as long as you have a result, the rpc reached the device: https://github.com/opendaylight/netconf/blob/master/netconf/sal-netconf-connector/src/main/java/org/opendaylight/netconf/sal/connect/netconf/sal/KeepaliveSalFacade.java#L228 |
| Comments |
| Comment by Alexis de Talhouët [ 10/Jul/17 ] |
|
Attachment keepalive-rcp-reply-error.log has been added with description: karaf.log |
| Comment by Alexis de Talhouët [ 10/Jul/17 ] |
|
proposed fix: https://git.opendaylight.org/gerrit/#/c/60152/ |