[NETCONF-45] defaulting access specifier Created: 29/Jun/15  Updated: 15/Mar/19  Resolved: 20/May/16

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Shashidhar Shekar Assignee: Unassigned
Resolution: Won't Do Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 3891

 Description   

public final class EXIParameters {
static final String EXI_PARAMETER_BYTE_ALIGNED = "byte-aligned";
static final String EXI_PARAMETER_BIT_PACKED = "bit-packed";
static final String EXI_PARAMETER_COMPRESSED = "compressed";
static final String EXI_PARAMETER_PRE_COMPRESSION = "pre-compression"

All the class elements defaulting to private , it is a better practice to mark them private

 Comments   
Comment by Robert Varga [ 13/Nov/15 ]

Move to NETCONFI project.

Comment by Shivani Pathak [ 19/Nov/15 ]

A new class can be created for all the constants defined in EXIParameter considering the bug same as of Bug#3895.

Comment by Shivani Pathak [ 19/Nov/15 ]

(In reply to Shashidhar Shekar from comment #0)
> public final class EXIParameters {
> static final String EXI_PARAMETER_BYTE_ALIGNED = "byte-aligned";
> static final String EXI_PARAMETER_BIT_PACKED = "bit-packed";
> static final String EXI_PARAMETER_COMPRESSED = "compressed";
> static final String EXI_PARAMETER_PRE_COMPRESSION = "pre-compression"
>
>
> All the class elements defaulting to private , it is a better practice to
> mark them private

These 4 parameters are used in NetconfStartExiMessage class as well that is why they are not marked as private.

Generated at Wed Feb 07 20:14:01 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.