[NETCONF-47] constants defined in Class Created: 30/Jun/15 Updated: 15/Mar/19 Resolved: 01/Oct/18 |
|
| Status: | Resolved |
| Project: | netconf |
| Component/s: | netconf |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Shashidhar Shekar | Assignee: | Jakub Morvay |
| Resolution: | Won't Do | Votes: | 0 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 3895 |
| Description |
|
public final class NetconfNotification Constants defined in the class can be part of a config file. This would ensure that if the values change it is not required to change code but just tweak some config parameters. |
| Comments |
| Comment by Robert Varga [ 13/Nov/15 ] |
|
Move to NETCONFI project. |
| Comment by Shivani Pathak [ 19/Nov/15 ] |
|
There is a class 'NetconfConstants.java' for defining constants in package 'org.opendaylight.netconf.api.util'. Constants used in NetconfNotification class can be moved to that class so as to utilize the existing class instead of creating a separate config file. |
| Comment by Shivani Pathak [ 25/Nov/15 ] |
|
Changes submitted : https://git.opendaylight.org/gerrit/#/c/30174/ |
| Comment by Shivani Pathak [ 02/Dec/15 ] |
|
Incorporated suggested changes in Patch 2. |
| Comment by Jakub Morvay [ 01/Oct/18 ] |
|
Closing this as won't do. NetconfConstants class contains constants to mark operation service factories that should be wired with CSS netconf endpoint. CSS is no longer present so the class itslef should be removed. I don't see that much of benefit to move constants from NetconfNotification class there (or anywhere). |