[NETCONF-479] OptimisticLockFailedException on controller-config when both odl-netconf-connector-ssh and odl-netconf-clustered-topology are installed Created: 17/Oct/17 Updated: 15/Mar/19 Resolved: 01/Oct/18 |
|
| Status: | Resolved |
| Project: | netconf |
| Component/s: | netconf |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | ||
| Reporter: | Vratko Polak | Assignee: | Jakub Morvay |
| Resolution: | Done | Votes: | 1 |
| Labels: | None | ||
| Remaining Estimate: | Not Specified | ||
| Time Spent: | Not Specified | ||
| Original Estimate: | Not Specified | ||
| Environment: |
Operating System: All |
||
| External issue ID: | 9307 |
| Description |
|
This happens only rarely, but this can make autorelease build fail, by failing SingleFeatureTest on some Distribution feature. Distribution knows the two features are incompatible when running on 3 node cluster, but this is failing in 1 node tests. Nevertheless, both features are pulled into odl-integration-compatible-with-all in current Oxygen builds: Looking at the log [0] from the SFT failure, we see this (after removing lines from unrelated features): 2017-10-17 05:36:00,548 | INFO | on-dispatcher-54 | NetconfTopologyUtils | 448 - org.opendaylight.netconf.topology-singleton - 1.4.0 | RemoteDevice {controller-config} : using the default directory cache/schema2017-10-17 05:36:00,564 | INFO | lt-dispatcher-22 | NetconfTopologyContext | 448 - org.opendaylight.netconf.topology-singleton - 1.4.0 | Master was selected: IpAddress [_ipv4Address=Ipv4Address [_value=127.0.0.1]] 2017-10-17 05:36:00,583 | INFO | on-dispatcher-50 | AbstractNetconfTopology | 194 - netconf-topology-config - 1.4.0 | Connecting RemoteDevice{Uri [_value=controller-config]} , with config Node{getNodeId=Uri [_value=controller-config], augmentations={interface org.opendaylight.yang.gen.v1.urn.opendaylight.netconf.node.topology.rev150114.NetconfNode=NetconfNode{getActorResponseWaitTime=5, getBetweenAttemptsTimeoutMillis=2000, getConcurrentRpcLimit=0, getConnectionTimeoutMillis=20000, getCredentials=LoginPassword{getPassword=admin, getUsername=admin, augmentations={}}, getDefaultRequestTimeoutMillis=60000, getHost=Host [_ipAddress=IpAddress [_ipv4Address=Ipv4Address [_value=127.0.0.1]]], getKeepaliveDelay=120, getMaxConnectionAttempts=0, getPort=PortNumber [_value=1830], getSchemaCacheDirectory=schema, getSleepFactor=1.5, isReconnectOnChangedSchema=true, isSchemaless=false, isTcpOnly=false}}} 2017-10-17 05:36:00,654 | INFO | lt-dispatcher-22 | RemoteDeviceConnectorImpl | 448 - org.opendaylight.netconf.topology-singleton - 1.4.0 | RemoteDevice{controller-config} : Adding keepalive facade. ]/node/node[ {(urn:TBD:params:xml:ns:yang:network-topology?revision=2013-10-21)node-id=controller-config}]. which ultimately leads to: Transaction(init) not committed correctly Can Netconf make the two features compatible, or should Distribution split their test features and fail if 1-node Netconf feature is found in 3-node Distribution feature tree, and vice versa? |
| Comments |
| Comment by Tomas Cere [ 17/Oct/17 ] |
|
There is no reason to pull in odl-netconf-connector-ssh unless you are using config subsystem still. unimgr should move towards odl-netconf-topology. |
| Comment by Michael Vorburger [ 26/Oct/17 ] |
|
distribution jobs fail A LOT due to this, and IMHO that's a PITA that is blocking productivity for everyone, and untenable. unimgr-dev has not reacted to https://lists.opendaylight.org/pipermail/unimgr-dev/2017-October/000470.html in 24 hours, and I would therefore like to propose https://git.opendaylight.org/gerrit/#/c/64761/ to work around this. Objections, anyone? |
| Comment by Vratko Polak [ 26/Oct/17 ] |
|
Currently I think Change-Id I9c80c4dd5c43365d4d46f2b5bf89dd1f0f22f57f [3] is stable enough (and better overall). [3] https://git.opendaylight.org/gerrit/#/q/I9c80c4dd5c43365d4d46f2b5bf89dd1f0f22f57f |
| Comment by Michael Vorburger [ 27/Oct/17 ] |
| Comment by Roshni kk [ 16/Mar/18 ] |
|
While installing the feature odl-netconf-clustered-topology (on a single node topology), the issue is still seen in Nitrogen SR2 also.
Please find the karaf.log ==================== Exception in thread "CommitFutures-2" java.lang.IllegalStateException: RemoteDevice{controller-config} Transaction(init) not committed correctly
|
| Comment by Jakub Morvay [ 01/Oct/18 ] |
|
This should be fixed with https://git.opendaylight.org/gerrit/#/c/64797/ Nitrogen is no longer supported, closing this issue. |