[NETCONF-49] Arguments can be made final Created: 30/Jun/15  Updated: 15/Mar/19  Resolved: 30/Nov/15

Status: Resolved
Project: netconf
Component/s: netconf
Affects Version/s: None
Fix Version/s: None

Type: Bug
Reporter: Shashidhar Shekar Assignee: Gaurav pande
Resolution: Done Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified
Environment:

Operating System: All
Platform: All

External issue ID: 3897

 Description   

class --> public class OrderedNormalizedNodeWriter

function -->

private SchemaNode findParentSchemaOnPath(SchemaContext schemaContext, SchemaPath path)

 Comments   
Comment by Robert Varga [ 13/Nov/15 ]

Move to NETCONFI project.

Comment by Gaurav pande [ 24/Nov/15 ]

Bug is resolved.Made the arguments for findParentSchemaOnPath as final.
Please see the patch below:

https://git.opendaylight.org/gerrit/#/c/30133/

Comment by Tomas Cere [ 24/Nov/15 ]

Hi,

Thanks for the patch.
For future reference don't change the status into RESOLVED - FIXED until it's merged, use waiting for review while it needs to be reviewed and merged. Resolved fixed effectively hides the bug unless you are looking for resolved bugs and if i wasn't on cc for this one i would've missed it. Also can you also put the bug as in progress when you start working on it, it helps with tracking overall.

Thanks

Comment by Gaurav pande [ 24/Nov/15 ]

Ok Thanks Tomas.
I will surely keep that in mind.

Comment by Gaurav pande [ 25/Nov/15 ]

Hi Tomas,

I have added the updated patch with the new changes suggested by you:
https://git.opendaylight.org/gerrit/#/c/30133/

Thanks

Generated at Wed Feb 07 20:14:02 UTC 2024 using Jira 8.20.10#820010-sha1:ace47f9899e9ee25d7157d59aa17ab06aee30d3d.